linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, marcel@holtmann.org,
	linux-kernel@vger.kernel.org, anssi.hannula@gmail.com,
	Jiri Slaby <jirislaby@gmail.com>
Subject: [PATCH 09/10] HID: add compat support
Date: Fri, 16 May 2008 11:49:22 +0200	[thread overview]
Message-ID: <1210931362-18422-9-git-send-email-jirislaby@gmail.com> (raw)
In-Reply-To: <1210931362-18422-8-git-send-email-jirislaby@gmail.com>

Add compat option to hid code to allow loading of all modules on
systems which don't allow autoloading because of old userspace.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
 Documentation/feature-removal-schedule.txt |    7 +++++++
 drivers/hid/Kconfig                        |   11 +++++++++++
 drivers/hid/Makefile                       |    4 ++++
 drivers/hid/hid-apple.c                    |    2 ++
 drivers/hid/hid-core.c                     |   12 ++++++++++++
 drivers/hid/hid-dummy.c                    |   13 +++++++++++++
 drivers/hid/hid-logitech.c                 |    2 ++
 include/linux/hid.h                        |   17 +++++++++++++++--
 8 files changed, 66 insertions(+), 2 deletions(-)
 create mode 100644 drivers/hid/hid-dummy.c

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 3c35d45..1564e87 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -289,6 +289,13 @@ Who:	Glauber Costa <gcosta@redhat.com>
 
 ---------------------------
 
+What:	remove HID compat support
+When:	2.6.29
+Why:	needed only as a temporary solution until distros fix themselves up
+Who:	Jiri Slaby <jirislaby@gmail.com>
+
+---------------------------
+
 What:	/sys/o2cb symlink
 When:	January 2010
 Why:	/sys/fs/o2cb is the proper location for this information - /sys/o2cb
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 9a9fd7d..ba9ca39 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -70,6 +70,17 @@ source "drivers/hid/usbhid/Kconfig"
 menu "Special HID drivers"
 	depends on HID
 
+config HID_COMPAT
+	bool "Load all HID drivers on hid core load"
+	---help---
+	Compatible option for older userspace. If you have system without udev
+	support of module loading through aliases and also old
+	module-init-tools which can't handle hid bus, choose Y here. Otherwise
+	say N. If you say N and your userspace is old enough, the only
+	functionality you loose is modules autoloading.
+
+	If unsure, say N.
+
 config HID_LOGITECH
 	tristate "Logitech"
 	default m
diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
index 8a5cbbe..ccc169d 100644
--- a/drivers/hid/Makefile
+++ b/drivers/hid/Makefile
@@ -8,6 +8,10 @@ obj-$(CONFIG_HID)		+= hid.o
 hid-$(CONFIG_HID_DEBUG)		+= hid-debug.o
 hid-$(CONFIG_HIDRAW)		+= hidraw.o
 
+ifdef CONFIG_HID_COMPAT
+obj-m				+= hid-dummy.o
+endif
+
 obj-$(CONFIG_HID_LOGITECH)	+= hid-logitech.o
 obj-$(CONFIG_HID_APPLE)		+= hid-apple.o
 
diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index b39d25c..325d27f 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -464,3 +464,5 @@ static void apple_exit(void)
 module_init(apple_init);
 module_exit(apple_exit);
 MODULE_LICENSE("GPL");
+
+HID_COMPAT_LOAD_DRIVER(hid_apple);
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index be080d4..5134d41 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1565,6 +1565,14 @@ void hid_unregister_driver(struct hid_driver *hdrv)
 }
 EXPORT_SYMBOL_GPL(hid_unregister_driver);
 
+#ifdef CONFIG_HID_COMPAT
+static void hid_compat_load(struct work_struct *ws)
+{
+	request_module("hid-dummy");
+}
+static DECLARE_WORK(hid_compat_work, hid_compat_load);
+#endif
+
 static int __init hid_init(void)
 {
 	int ret;
@@ -1579,6 +1587,10 @@ static int __init hid_init(void)
 	if (ret)
 		goto err_bus;
 
+#ifdef CONFIG_HID_COMPAT
+	schedule_work(&hid_compat_work);
+#endif
+
 	return 0;
 err_bus:
 	bus_unregister(&hid_bus_type);
diff --git a/drivers/hid/hid-dummy.c b/drivers/hid/hid-dummy.c
new file mode 100644
index 0000000..b426134
--- /dev/null
+++ b/drivers/hid/hid-dummy.c
@@ -0,0 +1,13 @@
+#include <linux/module.h>
+#include <linux/hid.h>
+
+static int __init hid_dummy_init(void)
+{
+	HID_COMPAT_CALL_DRIVER(hid_logitech);
+	HID_COMPAT_CALL_DRIVER(hid_apple);
+
+	return -EIO;
+}
+module_init(hid_dummy_init);
+
+MODULE_LICENSE("GPL");
diff --git a/drivers/hid/hid-logitech.c b/drivers/hid/hid-logitech.c
index 5b145c9..6a70ca9 100644
--- a/drivers/hid/hid-logitech.c
+++ b/drivers/hid/hid-logitech.c
@@ -72,3 +72,5 @@ static void lg_exit(void)
 module_init(lg_init);
 module_exit(lg_exit);
 MODULE_LICENSE("GPL");
+
+HID_COMPAT_LOAD_DRIVER(hid_logitech);
diff --git a/include/linux/hid.h b/include/linux/hid.h
index c67e5fe..447aed9 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -784,10 +784,23 @@ dbg_hid(const char *fmt, ...)
 	return 0;
 }
 #define dbg_hid_line dbg_hid
-#endif
+#endif /* HID_DEBUG */
 
 #define err_hid(format, arg...) printk(KERN_ERR "%s: " format "\n" , \
 		__FILE__ , ## arg)
-#endif
+#endif /* HID_FF */
+
+#ifdef CONFIG_HID_COMPAT
+#define HID_COMPAT_LOAD_DRIVER(name)	\
+void hid_compat_##name(void) { }	\
+EXPORT_SYMBOL(hid_compat_##name)
+#else
+#define HID_COMPAT_LOAD_DRIVER(name)
+#endif /* HID_COMPAT */
+#define HID_COMPAT_CALL_DRIVER(name)	do {	\
+	extern void hid_compat_##name(void);	\
+	hid_compat_##name();			\
+} while (0)
+
 #endif
 
-- 
1.5.4.5


  reply	other threads:[~2008-05-16  9:54 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-16  9:49 [PATCH 01/10] modpost: add support for hid Jiri Slaby
2008-05-16  9:49 ` [PATCH 02/10] HID: make a bus from hid code Jiri Slaby
2008-05-16  9:49   ` [PATCH 03/10] HID: hid, make parsing event driven Jiri Slaby
2008-05-16  9:49     ` [PATCH 04/10] HID: move ids into separate file Jiri Slaby
2008-05-16  9:49       ` [PATCH 05/10] HID: move usage input mapping to hid.h Jiri Slaby
2008-05-16  9:49         ` [PATCH 06/10] HID: move logitech report quirks Jiri Slaby
2008-05-16  9:49           ` [PATCH 07/10] HID: move ignore quirks Jiri Slaby
2008-05-16  9:49             ` [PATCH 08/10] HID: move apple quirks Jiri Slaby
2008-05-16  9:49               ` Jiri Slaby [this message]
2008-06-04  8:55                 ` [PATCH 09/10] HID: add compat support Jiri Kosina
2008-06-04  9:00                   ` Jiri Slaby
2009-01-24  5:55                 ` Jaswinder Singh Rajput
2009-01-25 13:03                   ` Jiri Slaby
2009-01-25 16:57                   ` Jiri Kosina
2009-01-25 17:11                     ` Jaswinder Singh Rajput
2008-06-04 14:13               ` [PATCH 08/10] HID: move apple quirks Jiri Kosina
2008-06-09 10:40                 ` Jiri Slaby
2008-06-04 12:16           ` [PATCH 06/10] HID: move logitech report quirks Jiri Kosina
2008-06-09 10:29             ` Jiri Slaby
2008-06-16 10:15               ` Jiri Kosina
2008-06-04 13:21           ` Jiri Kosina
2008-06-09 10:33             ` Jiri Slaby
2008-06-11 14:13               ` Jiri Kosina
2008-06-11 15:39                 ` Oliver Neukum
2008-06-11 18:35                   ` Jiri Slaby
2008-06-11 18:23                 ` Anssi Hannula
2008-05-19 13:36 ` [PATCH 01/10] modpost: add support for hid Jiri Kosina
2008-05-19 13:38   ` Jiri Slaby
2008-05-19 13:50 ` [PATCH v2] " Jiri Slaby
2008-06-05  9:26 ` [PATCH 01/10] " Jiri Kosina
2008-06-09 10:41   ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1210931362-18422-9-git-send-email-jirislaby@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=anssi.hannula@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).