linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: dtor@mail.ru
Cc: linux-input@vger.kernel.org, yoann.v@prelude-ids.com
Subject: Hang in mousedev_init
Date: Wed, 28 May 2008 11:49:42 -0400	[thread overview]
Message-ID: <1211989782.3079.68.camel@localhost.localdomain> (raw)

I have a report of a person who is booting a 2.6.25 based fedora kernel
and hanging in mounsedev_init().  Moving to our old 2.6.24 based fedora
kernels he doesn't see any problems.

we know its mousedev_init since we added initcall_debug and
mousedev_init() is called but never returns...

Doesn't look like many patches between then and now

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=3b04a61107dfe46dbfc1796298b59ca3c0a09cd9
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d182c10c842007984e12b3b816df2b10d997cc8e
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=a7097ff89c3204737a07eecbc83f9ae6002cc534

About the only thing my clueless eye noticed was in
d182c10c842007984e12b3b816df2b10d997cc8e

--- a/drivers/input/mousedev.c
+++ b/drivers/input/mousedev.c
@@ -1032,7 +1032,7 @@ static const struct input_device_id mousedev_ids[] = {
                .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
                        INPUT_DEVICE_ID_MATCH_KEYBIT |
                        INPUT_DEVICE_ID_MATCH_ABSBIT,
-               .evbit = { BIT(EV_KEY) | BIT(EV_ABS) | BIT(EV_SYN) },
+               .evbit = { BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS) },
                .keybit = { [BIT_WORD(BTN_LEFT)] = BIT_MASK(BTN_LEFT) },
                .absbit = { BIT_MASK(ABS_X) | BIT_MASK(ABS_Y) },
        },      /* Mouse-like device with absolute X and Y but ordinary

You dropped the | BIT(EV_SYN)   does that matter?  What could have
changed to cause a hang?  Any clues?


             reply	other threads:[~2008-05-28 15:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-28 15:49 Eric Paris [this message]
2008-05-28 17:32 ` Hang in mousedev_init Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211989782.3079.68.camel@localhost.localdomain \
    --to=eparis@redhat.com \
    --cc=dtor@mail.ru \
    --cc=linux-input@vger.kernel.org \
    --cc=yoann.v@prelude-ids.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).