From: Marcel Holtmann <marcel@holtmann.org>
To: Paul Collins <paul@burly.ondioline.org>
Cc: jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] [RESEND] fix HID quirks for aluminium apple wireless keyboards
Date: Thu, 12 Jun 2008 22:08:09 +0200 [thread overview]
Message-ID: <1213301289.17870.72.camel@violet.holtmann.net> (raw)
In-Reply-To: <874p7ylsj0.fsf@burly.wgtn.ondioline.org>
Hi Paul,
> I noticed that the quirks for Bluetooth Apple keyboards seem to have
> been incorrectly added to the USB HID, thus rendering them ineffective.
> Here is a patch that moves them to the Bluetooth HID. With this patch
> applied the Fn key on my Apple wireless keyboard now works as expected.
>
> I also took the liberty of adding defines for the vendor and for the
> existing Mighty Mouse quirk.
I prefer not to do this. I don't see any benefit or readability coming
out of it. Leave it as it is. Add the numeric ids and then a line on top
of it describing the devices.
Regards
Marcel
next prev parent reply other threads:[~2008-06-12 20:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 12:26 [PATCH] fix HID quirks for aluminium apple wireless keyboards Paul Collins
[not found] ` <87iqweltzo.fsf-D7l3p2TGOOdLdt5/z87VRY6ehsQQaF5K@public.gmane.org>
2008-06-12 12:57 ` [PATCH] [RESEND] " Paul Collins
2008-06-12 13:17 ` Phil Endecott
[not found] ` <1213276636216-YnoLgZYwwYuCbKHnblo0pmrPP3OPMK55cpQHUIT47Ck@public.gmane.org>
2008-06-12 14:55 ` Paul Collins
2008-06-12 20:08 ` Marcel Holtmann [this message]
2008-06-14 8:03 ` Paul Collins
2008-06-14 12:22 ` Marcel Holtmann
2008-06-17 13:54 ` Jiri Kosina
2008-06-14 12:51 ` Phil Endecott
2008-06-18 10:19 ` Paul Collins
2008-06-18 10:47 ` Phil Endecott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213301289.17870.72.camel@violet.holtmann.net \
--to=marcel@holtmann.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paul@burly.ondioline.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).