From: Daniel Walker <dwalker@mvista.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>, Philippe Troin <phil@fifi.org>,
"Adolfo R. Brandes" <arbrandes@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] input: push down scancode negative checking
Date: Mon, 30 Jun 2008 12:56:20 -0700 [thread overview]
Message-ID: <1214855780.5764.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20080630154701.ZZRA012@mailhub.coreip.homeip.net>
On Mon, 2008-06-30 at 15:47 -0400, Dmitry Torokhov wrote:
> On Mon, Jun 30, 2008 at 12:33:46PM -0700, Daniel Walker wrote:
> > The getkeycode/setkeycode calls should be able to accept "negative" values.
> >
> > The HID layer has some scan codes of the form 0xffbc0000 for logitech
> > devices, and they get ignored by these calls. I pushed the checking
> > into the input_default_* functions since they do need non-negative
> > values.
> >
> > I also corrected a typo in the comment for input_set_keycode
>
> Hmm, I wonder if we just need to type these as unsigned.
>
I think it would make sense, because AFAIK scancodes don't really have a
concept of signed-ness anyway .. I almost did it that way, but I wasn't
sure enough about the reasoning for the signed int ..
Daniel
next prev parent reply other threads:[~2008-06-30 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 19:33 [PATCH] input: push down scancode negative checking Daniel Walker
2008-06-30 19:47 ` Dmitry Torokhov
2008-06-30 19:56 ` Daniel Walker [this message]
2008-07-01 7:51 ` Jiri Kosina
2008-07-01 17:23 ` Daniel Walker
2008-07-07 19:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214855780.5764.3.camel@localhost.localdomain \
--to=dwalker@mvista.com \
--cc=arbrandes@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=phil@fifi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).