linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Reitmayr <treitmayr@devbase.at>
To: Linux-Input <linux-input@vger.kernel.org>
Subject: Usage of new KEY_NUMERIC_* codes in an existing driver (yealink)
Date: Fri, 22 Aug 2008 19:01:28 +0200	[thread overview]
Message-ID: <1219424488.6684.20.camel@localhost> (raw)

Hi,
I am in the process of extending the existing yealink driver, partly to
support various other models. The existing driver as included in the
current kernel uses the shift key to report the keys "*" and "#", but I
am hesitating to do the same bad "trick" for the other models.

As I would like to eventually submit the extended driver upstream, what
is the recommended strategy in my situation regarding usage of the new
KEY_NUMERIC_* codes? Use them only for the new models (which would
result in an ugly mix), or also update the codes for the existing
USB-P1K model (which would break userspace programs but finally fix
things for some foreign keyboard layouts), or for the existing USB-P1K
model report the old and the new codes (which might look like two key
presses)?

Thanks for your advice,
-Thomas

PS: The updated driver is available at
http://www.devbase.at/svn/view.cgi/yealink-module/trunk/?root=voip
(still including #if's reg. kernel versions, some comments to be
corrected, etc.)


             reply	other threads:[~2008-08-22 19:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-22 17:01 Thomas Reitmayr [this message]
2008-08-22 20:02 ` Usage of new KEY_NUMERIC_* codes in an existing driver (yealink) Dmitry Torokhov
2008-08-23 12:39   ` Thomas Reitmayr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219424488.6684.20.camel@localhost \
    --to=treitmayr@devbase.at \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).