From: Stelian Pop <stelian@popies.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: appletouch - driver refactoring
Date: Sun, 12 Oct 2008 18:00:57 +0200 [thread overview]
Message-ID: <1223827257.11389.1.camel@galileo> (raw)
In-Reply-To: <1223823289.10176.9.camel@johannes.berg>
Le dimanche 12 octobre 2008 à 16:54 +0200, Johannes Berg a écrit :
> Looks nice, will give it a test later, just a small comment.
[...]
> > +static struct atp_info fountain_info = {
[...]
> > +static struct atp_info geyser1_info = {
[...]
> And there are only three uses. Do we expect to add new uses of the
> types, especially different structs that share the type? Otherwise I'd
> suggest to use
>
> if (dev->info == &geyser2_info) and &fountain_info respectively and just
> remove the type thing completely.
I agree. Updated patch is coming.
--
Stelian Pop <stelian@popies.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-12 16:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 8:49 [PATCH] appletouch driver refactoring Stelian Pop
2008-10-11 3:21 ` Dmitry Torokhov
2008-10-12 14:41 ` Stelian Pop
2008-10-12 14:44 ` [PATCH] Input: appletouch - " Stelian Pop
2008-10-12 14:54 ` Johannes Berg
2008-10-12 16:00 ` Stelian Pop [this message]
2008-10-12 16:03 ` [PATCH v3] " Stelian Pop
2008-10-13 9:45 ` Johannes Berg
2008-10-14 2:57 ` Dmitry Torokhov
2008-10-14 8:10 ` Johannes Berg
2008-10-28 3:03 ` Dmitry Torokhov
2008-10-28 7:23 ` Johannes Berg
2008-10-29 16:01 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223827257.11389.1.camel@galileo \
--to=stelian@popies.net \
--cc=dmitry.torokhov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).