Re: [PATCH v3] Input: appletouch - driver refactoring

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On Sun, 2008-10-12 at 18:03 +0200, Stelian Pop wrote:
> The appletouch driver has grown up from supporting only a couple of
> touchpads into supporting many touchpads, which can have different
> number of sensors, different aspect ratios etc.
> 
> This patch cleans up the current driver code and makes it easy to
> support the features of each different touchpad.
> 
> As a side effect, this patch also modifies the 'Y' multiplication factor
> of the 'geyser3' and 'geyser4' touchpads (found on Core Duo and Core2
> Duo MacBook and MacBook Pro laptops) in order to make the touchpad
> output match the aspect ratio of the touchpad (Y factor changed from 43
> to 64).

Looks good, the only thing I can find to complain about is that you
modify


> +static struct atp_info geyser1_info = {
> +	.xsensors	= 16,		/* will be set to 26 on 17" */

those static variables ;)

Considering these devices aren't available outside of apple laptops and
those always come with exactly one, I don't think it's much of a
problem.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]