From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: linux-input@vger.kernel.org
Cc: linux-omap@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Tony Lindgren <tony@atomide.com>
Subject: [PATCH 2/2] OMAP2: omap-keypad: Enable more than 6 rows
Date: Thu, 23 Oct 2008 08:51:32 +0300 [thread overview]
Message-ID: <1224741092-21577-3-git-send-email-peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <1224741092-21577-2-git-send-email-peter.ujfalusi@nokia.com>
There is no reason to limit the GPIO rows to 6 for
OMAP2.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/input/keyboard/omap-keypad.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c
index d6cd79b..0f95046 100644
--- a/drivers/input/keyboard/omap-keypad.c
+++ b/drivers/input/keyboard/omap-keypad.c
@@ -137,7 +137,7 @@ static void omap_kp_scan_keypad(struct omap_kp *omap_kp, unsigned char *state)
/* read the keypad status */
for (col = 0; col < omap_kp->cols; col++) {
set_col_gpio_val(omap_kp, ~(1 << col));
- state[col] = ~(get_row_gpio_val(omap_kp)) & 0x3f;
+ state[col] = ~(get_row_gpio_val(omap_kp)) & 0xff;
}
set_col_gpio_val(omap_kp, 0);
--
1.5.6.4
next prev parent reply other threads:[~2008-10-23 5:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 5:51 [PATCH 0/2] omap-keypad fixes for OMAP2 Peter Ujfalusi
2008-10-23 5:51 ` [PATCH 1/1] OMAP2: omap-keypad: interrupt disable fix Peter Ujfalusi
2008-10-23 5:51 ` Peter Ujfalusi [this message]
2008-10-29 3:55 ` [PATCH 0/2] omap-keypad fixes for OMAP2 Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224741092-21577-3-git-send-email-peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).