From: Johannes Berg <johannes@sipsolutions.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Stelian Pop <stelian@popies.net>, linux-input@vger.kernel.org
Subject: Re: [PATCH v3] Input: appletouch - driver refactoring
Date: Tue, 28 Oct 2008 08:23:54 +0100 [thread overview]
Message-ID: <1225178634.3796.56.camel@johannes.berg> (raw)
In-Reply-To: <20081028030355.GA2898@anvil.corenet.prv> (sfid-20081028_040402_139480_41C02D8C)
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Mon, 2008-10-27 at 23:03 -0400, Dmitry Torokhov wrote:
> > > +static struct atp_info geyser1_info = {
> > > + .xsensors = 16, /* will be set to 26 on 17" */
> >
> > those static variables ;)
> >
> > Considering these devices aren't available outside of apple laptops and
> > those always come with exactly one, I don't think it's much of a
> > problem.
> >
>
> How about if we do this:
>
> Input: appletouch - small fixup to Stelians patch
looks good to me, thanks!
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-10-28 7:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 8:49 [PATCH] appletouch driver refactoring Stelian Pop
2008-10-11 3:21 ` Dmitry Torokhov
2008-10-12 14:41 ` Stelian Pop
2008-10-12 14:44 ` [PATCH] Input: appletouch - " Stelian Pop
2008-10-12 14:54 ` Johannes Berg
2008-10-12 16:00 ` Stelian Pop
2008-10-12 16:03 ` [PATCH v3] " Stelian Pop
2008-10-13 9:45 ` Johannes Berg
2008-10-14 2:57 ` Dmitry Torokhov
2008-10-14 8:10 ` Johannes Berg
2008-10-28 3:03 ` Dmitry Torokhov
2008-10-28 7:23 ` Johannes Berg [this message]
2008-10-29 16:01 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225178634.3796.56.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=stelian@popies.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).