From: Harvey Harrison <harvey.harrison@gmail.com>
To: akpm@linux-foundation.org
Cc: dtor@mail.ru, linux-input@vger.kernel.org
Subject: Re: [patch 3/8] input: ads7846.c sparse lock annotation
Date: Mon, 01 Dec 2008 15:18:48 -0800 [thread overview]
Message-ID: <1228173529.5482.9.camel@brick> (raw)
In-Reply-To: <200812012220.mB1MKERa012626@imap1.linux-foundation.org>
On Mon, 2008-12-01 at 14:20 -0800, akpm@linux-foundation.org wrote:
> From: Harvey Harrison <harvey.harrison@gmail.com>
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
Small nit with this patch I just noticed (sorry). It's more
conventional to do the annotation in the other order (was done
late after some other annotations), please apply the following instead:
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -761,6 +761,8 @@ static irqreturn_t ads7846_irq(int irq, void *handle)
/* Must be called with ts->lock held */
static void ads7846_disable(struct ads7846 *ts)
+__releases(&ts->lock)
+__acquires(&ts->lock)
{
if (ts->disabled)
return;
prev parent reply other threads:[~2008-12-01 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 22:20 [patch 3/8] input: ads7846.c sparse lock annotation akpm
2008-12-01 23:18 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228173529.5482.9.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dtor@mail.ru \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).