* [patch 3/8] input: ads7846.c sparse lock annotation
@ 2008-12-01 22:20 akpm
2008-12-01 23:18 ` Harvey Harrison
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-12-01 22:20 UTC (permalink / raw)
To: dtor; +Cc: linux-input, akpm, harvey.harrison
From: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/input/touchscreen/ads7846.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN drivers/input/touchscreen/ads7846.c~input-ads7846c-sparse-lock-annotation drivers/input/touchscreen/ads7846.c
--- a/drivers/input/touchscreen/ads7846.c~input-ads7846c-sparse-lock-annotation
+++ a/drivers/input/touchscreen/ads7846.c
@@ -761,6 +761,8 @@ static irqreturn_t ads7846_irq(int irq,
/* Must be called with ts->lock held */
static void ads7846_disable(struct ads7846 *ts)
+__acquires(&ts->lock)
+__releases(&ts->lock)
{
if (ts->disabled)
return;
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 3/8] input: ads7846.c sparse lock annotation
2008-12-01 22:20 [patch 3/8] input: ads7846.c sparse lock annotation akpm
@ 2008-12-01 23:18 ` Harvey Harrison
0 siblings, 0 replies; 2+ messages in thread
From: Harvey Harrison @ 2008-12-01 23:18 UTC (permalink / raw)
To: akpm; +Cc: dtor, linux-input
On Mon, 2008-12-01 at 14:20 -0800, akpm@linux-foundation.org wrote:
> From: Harvey Harrison <harvey.harrison@gmail.com>
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
Small nit with this patch I just noticed (sorry). It's more
conventional to do the annotation in the other order (was done
late after some other annotations), please apply the following instead:
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -761,6 +761,8 @@ static irqreturn_t ads7846_irq(int irq, void *handle)
/* Must be called with ts->lock held */
static void ads7846_disable(struct ads7846 *ts)
+__releases(&ts->lock)
+__acquires(&ts->lock)
{
if (ts->disabled)
return;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-01 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-01 22:20 [patch 3/8] input: ads7846.c sparse lock annotation akpm
2008-12-01 23:18 ` Harvey Harrison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).