From: Adrian McMenamin <adrian@newgolddream.dyndns.info>
To: Mike Frysinger <vapier@gentoo.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-sh <linux-sh@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH] sh: maple: add support for the Maple mouse on the SEGA Dreamcast
Date: Mon, 29 Dec 2008 21:38:34 +0000 [thread overview]
Message-ID: <1230586714.6496.29.camel@localhost.localdomain> (raw)
In-Reply-To: <200812291636.36303.vapier@gentoo.org>
On Mon, 2008-12-29 at 16:36 -0500, Mike Frysinger wrote:
> On Monday 29 December 2008 16:30:14 Adrian McMenamin wrote:
> > +static int __devexit remove_maple_mouse(struct device *dev)
> > +static struct maple_driver dc_mouse_driver = {
> > + .drv = {
> > + .remove = remove_maple_mouse,
>
> does that really build warning free ? usually you need __devexit_p() in the
> .remove assignment ...
> -mike
Yep
adrian@bossclass:~/linux-2.6$ make ARCH=sh
CROSS_COMPILE=/home/adrian/dreamy-linux/buildroot/build_sh4/staging_dir/bin/sh4-linux- zImage modules -j4
scripts/kconfig/conf -s arch/sh/Kconfig
CHK include/linux/version.h
SYMLINK include/asm -> include/asm-sh
make[1]: `include/asm-sh/machtypes.h' is up to date.
CHK include/linux/utsrelease.h
UPD include/linux/utsrelease.h
CALL scripts/checksyscalls.sh
CHK include/linux/compile.h
CC init/version.o
CC kernel/module.o
LD init/built-in.o
CC [M] drivers/input/mouse/maplemouse.o
LD kernel/built-in.o
next prev parent reply other threads:[~2008-12-29 21:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 19:17 [PATCH] sh: maple: add support for the Maple mouse on the SEGA Dreamcast Adrian McMenamin
2008-12-29 21:02 ` Mike Frysinger
2008-12-29 21:30 ` Adrian McMenamin
2008-12-29 21:36 ` Mike Frysinger
2008-12-29 21:38 ` Adrian McMenamin [this message]
2008-12-29 21:46 ` Sam Ravnborg
2008-12-29 22:17 ` Adrian McMenamin
2008-12-29 22:19 ` Mike Frysinger
2008-12-30 8:17 ` Dmitry Torokhov
2008-12-30 20:27 ` Adrian McMenamin
2009-01-01 7:41 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1230586714.6496.29.camel@localhost.localdomain \
--to=adrian@newgolddream.dyndns.info \
--cc=akpm@osdl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).