From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaswinder Singh Rajput Subject: Re: [PATCH 09/10] HID: add compat support Date: Sun, 25 Jan 2009 22:41:38 +0530 Message-ID: <1232903498.10995.2.camel@localhost.localdomain> References: <1210931362-18422-1-git-send-email-jirislaby@gmail.com> <1210931362-18422-2-git-send-email-jirislaby@gmail.com> <1210931362-18422-3-git-send-email-jirislaby@gmail.com> <1210931362-18422-4-git-send-email-jirislaby@gmail.com> <1210931362-18422-5-git-send-email-jirislaby@gmail.com> <1210931362-18422-6-git-send-email-jirislaby@gmail.com> <1210931362-18422-7-git-send-email-jirislaby@gmail.com> <1210931362-18422-8-git-send-email-jirislaby@gmail.com> <1210931362-18422-9-git-send-email-jirislaby@gmail.com> <3f9a31f40901232155q7f898f00l9a1cf16ca6c8fb75@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:44737 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbZAYRMV (ORCPT ); Sun, 25 Jan 2009 12:12:21 -0500 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Jaswinder Singh Rajput , Jiri Slaby , Dmitry Torokhov , linux-input@vger.kernel.org, marcel@holtmann.org, linux-kernel@vger.kernel.org, anssi.hannula@gmail.com, gregkh@suse.de, Sam Ravnborg , Ingo Molnar On Sun, 2009-01-25 at 17:57 +0100, Jiri Kosina wrote: > On Sat, 24 Jan 2009, Jaswinder Singh Rajput wrote: > > > This leads to 3 headers_check warnings: > > > > usr/include/linux/hid.h:66: leaks CONFIG_HID to userspace where it is not valid > > usr/include/linux/hid.h:69: extern's make no sense in userspace > > usr/include/linux/hid.h:76: extern's make no sense in userspace > > > > So I am moving whole above block in #ifdef __KEREL__ > > > > If you have any objections, then let me know, now it will look like this: > > > > #endif /* HID_FF */ > > > > +#ifdef __KERNEL__ > > #ifdef CONFIG_HID_COMPAT > > #define HID_COMPAT_LOAD_DRIVER(name) \ > > /* prototype to avoid sparse warning */ \ > > @@ -804,6 +805,7 @@ EXPORT_SYMBOL(hid_compat_##name) > > extern void hid_compat_##name(void); \ > > hid_compat_##name(); \ > > } while (0) > > +#endif /* __KERNEL__ */ > > > > #endif > > Thanks for catching this. Could you please resend the patch to me, with > proper changelog and Signed-off-by: line? Thanks. > I have already send the patchset to Ingo "Re: [GIT PULL -tip] fix 22 make headers_check - 200901" and I also CCed to you jirislaby@gmail.com -- JSR