From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian McMenamin Subject: Re: [PATCH] sh: maple: add support for Visual Memory Card devices, and make consequential changes to maple input drivers - 2/3 - v5 Date: Mon, 09 Feb 2009 21:41:56 +0000 Message-ID: <1234215716.6756.18.camel@localhost.localdomain> References: <1234122069.6736.8.camel@localhost.localdomain> <20090209065632.GA21980@linux-sh.org> <1234207053.6756.11.camel@localhost.localdomain> <200902091433.57126.vapier@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from mk-filter-1-a-1.mail.uk.tiscali.com ([212.74.100.52]:15112 "EHLO mk-filter-1-a-1.mail.uk.tiscali.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbZBIVnQ (ORCPT ); Mon, 9 Feb 2009 16:43:16 -0500 In-Reply-To: <200902091433.57126.vapier@gentoo.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Mike Frysinger Cc: Paul Mundt , Greg KH , Dmitry Torokhov , dwmw2 , LKML , MTD , linux-sh , linux-input On Mon, 2009-02-09 at 14:33 -0500, Mike Frysinger wrote: > > then you'd end up with 4 clearly marked files (assuming your log message for > each change is clear). in the summary, you should then make statements like: > Patch 1 (... subject ...) in this series can be applied by itself for the bus > driver. Then patch 2 (... subject ...) and 3 (... subject ...) can be applied > as they need the bus changes. > -mike Fair enough. I ought to resubmit patches anyway because previous code has a memory leak/race which I've now fixed with a couple of extra lines. But the basic point here is that changing the bus code is necessary to get the VMU driver (or *any* VMU driver) to work, but changing the bus driver also breaks the two existing drivers in mainline that use the bus. The breakage in terms of lines to be fixed is small, but it still needs to be done 'all at once'.