From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: lockdep and threaded IRQs Date: Tue, 03 Mar 2009 00:02:23 +0100 Message-ID: <1236034943.5330.1779.camel@laptop> References: <1236030106.5330.1553.camel@laptop> <200903021409.21344.david-b@pacbell.net> <1236032371.5330.1654.camel@laptop> <20090302.144647.116847598.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:43774 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752860AbZCBXCo (ORCPT ); Mon, 2 Mar 2009 18:02:44 -0500 In-Reply-To: <20090302.144647.116847598.davem@davemloft.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: David Miller Cc: dbrownell@users.sourceforge.net, tglx@linutronix.de, akpm@linux-foundation.org, me@felipebalbi.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, felipe.balbi@nokia.com, dmitry.torokhov@gmail.com, sameo@openedhand.com On Mon, 2009-03-02 at 14:46 -0800, David Miller wrote: > From: Peter Zijlstra > Date: Mon, 02 Mar 2009 23:19:31 +0100 > > > I state that every !IRQF_DISABLED usage is a bug, either due to broken > > hardware or broken drivers. > > We'll send you the bill to have everyone's hardware > replaced :-) I'm not saying to remove support for such stuff, as long as we clearly annotate that its due to broken ass hardware we can leave a IRQF_ENABLED thingy in there. Preferably such drivers would be converted to threaded interrupts, but I thought Alan mentioned an IDE chipset that was so broken even that would be impossible (could not mask the IRQ for it would corrupt stuff). The thing I am strongly opposing though, is keeping interrupts enabled for regular drivers on sane hardware.