From: Richard Hughes <hughsient@gmail.com>
To: Harald Welte <laforge@gnumonks.org>
Cc: linux-acpi <linux-acpi@vger.kernel.org>,
Peter Hutterer <peter.hutterer@redhat.com>, mjg <mjg@redhat.com>,
linux-input <linux-input@vger.kernel.org>,
Matthias Clasen <mclasen@redhat.com>
Subject: [PATCH] panasonic-laptop: use correct key names for sleep states in driver
Date: Wed, 04 Mar 2009 10:58:26 +0000 [thread overview]
Message-ID: <1236164306.3936.20.camel@hughsie-work.lan> (raw)
In-Reply-To: <1236164049.3936.17.camel@hughsie-work.lan>
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
On Wed, 2009-03-04 at 10:54 +0000, Richard Hughes wrote:
> On Mon, 2009-03-02 at 08:24 -0300, Henrique de Moraes Holschuh wrote:
> > FWIW, I think it is a good idea, and I'd take patches for
> > thinkpad-acpi.
>
> Patch attached for thinkpad-acpi. KEY_HIBERNATE is already in
> linux-next, but has not yet been pushed to master. Please review,
> thanks.
Patch also attached for panasonic-laptop. Harald, can you please review
this. Thanks.
Richard
[-- Attachment #2: 0003-panasonic-laptop-use-correct-key-names-for-sleep-ke.patch --]
[-- Type: text/x-patch, Size: 1447 bytes --]
>From 11df58e5c55e6286f03b29b6b9820ed4b13095db Mon Sep 17 00:00:00 2001
From: Richard Hughes <richard@hughsie.com>
Date: Wed, 4 Mar 2009 10:57:36 +0000
Subject: panasonic-laptop: use correct key names for sleep keys in driver
Use the new key KEY_HIBERNATE and correct the use of KEY_SUSPEND.
KEY_HIBERNATE is used when the decal on the key indicates sleep to disk,
KEY_SUSPEND is used when the decal indicates sleep to memory, and
KEY_SLEEP is used when the sleep type is unknown or unspecified
We've already converted Xorg, HAL, and most of userspace to use the same names.
With this patch, the sleep keys can be labeled consistently all the way
through the stack. More patches to other device drivers are to follow.
Signed-off-by: Richard Hughes <hughsient@gmail.com>
---
drivers/platform/x86/panasonic-laptop.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/panasonic-laptop.c b/drivers/platform/x86/panasonic-laptop.c
index c47a44d..63a1828 100644
--- a/drivers/platform/x86/panasonic-laptop.c
+++ b/drivers/platform/x86/panasonic-laptop.c
@@ -205,10 +205,10 @@ static const int initial_keymap[KEYMAP_SIZE] = {
/* 4 */ KEY_MUTE,
/* 5 */ KEY_VOLUMEDOWN,
/* 6 */ KEY_VOLUMEUP,
- /* 7 */ KEY_SLEEP,
+ /* 7 */ KEY_SUSPEND,
/* 8 */ KEY_PROG1, /* Change CPU boost */
/* 9 */ KEY_BATTERY,
- /* 10 */ KEY_SUSPEND,
+ /* 10 */ KEY_HIBERNATE,
};
struct pcc_acpi {
--
1.6.1.3
next prev parent reply other threads:[~2009-03-04 10:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 11:13 suspend / hibernate nomenclature Richard Hughes
2009-03-02 11:24 ` Henrique de Moraes Holschuh
2009-03-02 12:11 ` Richard Hughes
2009-03-03 17:20 ` [patch] add KEY_HIBERNATE and clarify the uses of KEY_SUSPEND and KEY_SLEEP Richard Hughes
2009-03-03 19:53 ` Rafael J. Wysocki
2009-03-04 8:42 ` Dmitry Torokhov
2009-03-04 10:54 ` [PATCH] thinkpad-acpi: use correct key names for sleep states in driver Richard Hughes
2009-03-04 10:58 ` Richard Hughes [this message]
2009-03-04 23:58 ` [PATCH] panasonic-laptop: " Harald Welte
2009-03-05 9:09 ` Richard Hughes
2009-03-04 11:09 ` [PATCH] DVB-USB: correct the comment about KEY_SLEEP Richard Hughes
2009-03-10 10:31 ` Antti Palosaari
2009-03-04 12:04 ` [PATCH] thinkpad-acpi: use correct key names for sleep states in driver Henrique de Moraes Holschuh
2009-08-18 20:02 ` Yves-Alexis Perez
2009-08-18 20:10 ` Matthew Garrett
2009-08-18 20:27 ` Yves-Alexis Perez
2009-08-18 20:45 ` Matthew Garrett
2009-08-22 18:02 ` Henrique de Moraes Holschuh
2009-08-19 9:18 ` Ali Abdallah
2009-08-26 11:36 ` Yves-Alexis Perez
2009-08-26 13:43 ` Matthew Garrett
2009-08-26 17:52 ` Yves-Alexis Perez
2009-08-26 22:51 ` Henrique de Moraes Holschuh
2009-08-27 6:18 ` Dmitry Torokhov
2009-08-28 0:34 ` Henrique de Moraes Holschuh
2009-03-07 8:37 ` suspend / hibernate nomenclature Andrey Borzenkov
2009-03-07 15:48 ` Matthew Garrett
2009-03-07 16:41 ` Henrique de Moraes Holschuh
2009-03-07 16:48 ` Matthew Garrett
2009-03-07 17:17 ` Henrique de Moraes Holschuh
2009-03-07 20:25 ` Richard Hughes
2009-03-07 20:39 ` Matthew Garrett
2009-03-08 8:45 ` Richard Hughes
2009-03-08 14:41 ` Matthew Garrett
2009-03-08 20:56 ` Rafael J. Wysocki
2009-03-08 23:07 ` Dmitry Torokhov
2009-03-08 23:19 ` Matthew Garrett
2009-03-09 13:52 ` Ville Syrjälä
2009-03-09 14:00 ` Matthew Garrett
2009-03-09 15:10 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236164306.3936.20.camel@hughsie-work.lan \
--to=hughsient@gmail.com \
--cc=laforge@gnumonks.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mclasen@redhat.com \
--cc=mjg@redhat.com \
--cc=peter.hutterer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).