From: "Duje Mihanović" <duje.mihanovic@skole.hr>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Russell King" <linux@armlinux.org.uk>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] input/navpoint: remove driver
Date: Tue, 16 Jan 2024 20:45:43 +0100 [thread overview]
Message-ID: <12362783.O9o76ZdvQC@radijator> (raw)
In-Reply-To: <ZabS88WnVz9avRv2@google.com>
Hello Dmitry,
On Tuesday, January 16, 2024 8:03:15 PM CET Dmitry Torokhov wrote:
> On Tue, Jan 16, 2024 at 07:17:48PM +0100, Duje Mihanović wrote:
> > This driver does not use the SPI core as it should, instead tampering
> > with the SSP registers manually. Besides this, it relies on the global
> > GPIO namespace. Refactoring the driver is almost certainly not worth it
> > as it was seemingly only implemented in the HP iPAQ hx4700 removed more
> > than a year ago in d6df7df7ae5a ("ARM: pxa: remove unused board files"),
> > so let's remove it.
>
> I think this clashed with some recent cleanups to the navpoint driver.
> Could you please re-generate the patch against linux-next or my "next"
> branch please?
I have done it. Should I wait a bit (how much?) before resending or is it okay
to send v2 right away in this case?
Regards,
--
Duje
next prev parent reply other threads:[~2024-01-16 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 18:17 [PATCH 0/2] input/navpoint: remove driver Duje Mihanović
2024-01-16 18:17 ` [PATCH 1/2] ARM: pxa: drop MOUSE_NAVPOINT_PXA27x from defconfig Duje Mihanović
2024-01-16 18:17 ` [PATCH 2/2] input/navpoint: remove driver Duje Mihanović
2024-01-16 19:03 ` Dmitry Torokhov
2024-01-16 19:45 ` Duje Mihanović [this message]
2024-01-16 19:47 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12362783.O9o76ZdvQC@radijator \
--to=duje.mihanovic@skole.hr \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox