From: Bastien Nocera <hadess@hadess.net>
To: Ping <pinglinux@gmail.com>
Cc: Andrew Zabolotny <zap@homelink.ru>, linux-input@vger.kernel.org
Subject: Re: Subject: Re: [PATCH] Wacom Graphire Bluetooth driver (updated with a few fixes)
Date: Fri, 01 May 2009 14:15:34 +0100 [thread overview]
Message-ID: <1241183734.20413.123.camel@cookie.hadess.net> (raw)
In-Reply-To: <167e8a330904280834i23dac0e0n3f859ced30a3e4a7@mail.gmail.com>
On Tue, 2009-04-28 at 08:34 -0700, Ping wrote:
> Hi Bastien,
>
> Thank you for putting the Wacom Bluethooth support together. I have
> two questions (I have to admit that I know nothing about Bluethooth.
> I know something about Wacom devices though :):
>
> 1. Should we follow the USB way to blacklist all Wacom
> Bluetooth devices so we don't have to add each product ID later on?
> Something like this should work (correct me if I am wrong):
>
> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_WACOM, HID_ANY_ID) },
>
> instead of
>
> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_WACOM,
> USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH) },
We don't know whether the other Bluetooth tablets that appear will use
the same protocol. New devices wouldn't work as tablets, and they
wouldn't work as mice either, because we blacklisted them.
> 2. Is it possible to merge hid/hid-wacom.c into
> input/tablet/wacom*? From maintenance point of view, this would be
> easier for people to update the driver with future support (one place
> handles all common data between USB and Bluetooth devices of the
> similar models).
Yes, that's really what should happen, but until somebody actually does
the job, it's unlikely to happen. It's not that big a problem right now,
as the Bluetooth and USB devices don't share a protocol.
> I am glad to see that Wacom Bluetooth support is getting into the main
> stream.
I'm actually still waiting for the patch to make it into the input
tree...
parent reply other threads:[~2009-05-01 13:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <167e8a330904280834i23dac0e0n3f859ced30a3e4a7@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241183734.20413.123.camel@cookie.hadess.net \
--to=hadess@hadess.net \
--cc=linux-input@vger.kernel.org \
--cc=pinglinux@gmail.com \
--cc=zap@homelink.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).