From: Tero Saarni <tero.saarni@gmail.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org
Subject: [PATCH] Input: synaptics - add support for reporting x/y resolution
Date: Mon, 04 May 2009 21:06:09 +0300 [thread overview]
Message-ID: <1241460369.29685.6.camel@hp> (raw)
Synaptics uses anisotropic coordinate system. On wide touchpads
vertical coordinate resolution can be twice as high as horizontal
leading to unequal sensitivity. Make x and y coordinate resolution
available so that differences can be compensated.
Signed-off-by: Tero Saarni <tero.saarni@gmail.com>
---
drivers/input/mouse/synaptics.c | 27 +++++++++++++++++++++++++++
drivers/input/mouse/synaptics.h | 2 ++
include/linux/input.h | 2 ++
3 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c
b/drivers/input/mouse/synaptics.c
index f3e4f7b..9363953 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -180,6 +180,29 @@ static int synaptics_identify(struct psmouse
*psmouse)
return -1;
}
+/*
+ * Read touchpad resolution
+ * Resolution is left zero if touchpad does not support the query
+ */
+static int synaptics_resolution(struct psmouse *psmouse)
+{
+ struct synaptics_data *priv = psmouse->private;
+ unsigned char res[3];
+
+ if (SYN_ID_MAJOR(priv->identity) < 4)
+ return 0;
+
+ if (synaptics_send_cmd(psmouse, SYN_QUE_RESOLUTION, res))
+ return 0;
+
+ if (res[1] == 0x80) {
+ priv->x_res = res[0];
+ priv->y_res = res[2];
+ }
+
+ return 0;
+}
+
static int synaptics_query_hardware(struct psmouse *psmouse)
{
if (synaptics_identify(psmouse))
@@ -188,6 +211,8 @@ static int synaptics_query_hardware(struct psmouse
*psmouse)
return -1;
if (synaptics_capability(psmouse))
return -1;
+ if (synaptics_resolution(psmouse))
+ return -1;
return 0;
}
@@ -534,6 +559,8 @@ static void set_input_params(struct input_dev *dev,
struct synaptics_data *priv)
set_bit(EV_ABS, dev->evbit);
input_set_abs_params(dev, ABS_X, XMIN_NOMINAL, XMAX_NOMINAL, 0, 0);
input_set_abs_params(dev, ABS_Y, YMIN_NOMINAL, YMAX_NOMINAL, 0, 0);
+ input_set_abs_params(dev, ABS_RESX, 0, priv->x_res, 0, 0);
+ input_set_abs_params(dev, ABS_RESY, 0, priv->y_res, 0, 0);
input_set_abs_params(dev, ABS_PRESSURE, 0, 255, 0, 0);
set_bit(ABS_TOOL_WIDTH, dev->absbit);
diff --git a/drivers/input/mouse/synaptics.h
b/drivers/input/mouse/synaptics.h
index 02aa4cf..e9a69c9 100644
--- a/drivers/input/mouse/synaptics.h
+++ b/drivers/input/mouse/synaptics.h
@@ -101,6 +101,8 @@ struct synaptics_data {
unsigned char pkt_type; /* packet type - old, new, etc */
unsigned char mode; /* current mode byte */
int scroll;
+ int x_res; /* x resolution in units/mm */
+ int y_res; /* y resolution in units/mm */
};
int synaptics_detect(struct psmouse *psmouse, int set_properties);
diff --git a/include/linux/input.h b/include/linux/input.h
index 0e6ff5d..53db780 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -645,6 +645,8 @@ struct input_absinfo {
#define ABS_TILT_Y 0x1b
#define ABS_TOOL_WIDTH 0x1c
#define ABS_VOLUME 0x20
+#define ABS_RESX 0x26
+#define ABS_RESY 0x27
#define ABS_MISC 0x28
#define ABS_MT_TOUCH_MAJOR 0x30 /* Major axis of touching ellipse */
--
1.6.0.4
next reply other threads:[~2009-05-04 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 18:06 Tero Saarni [this message]
2009-05-04 18:19 ` [PATCH] Input: synaptics - add support for reporting x/y resolution Tero Saarni
2009-05-05 7:20 ` Tero Saarni
2009-05-07 16:49 ` Dmitry Torokhov
2009-05-07 18:59 ` Tero Saarni
2009-05-08 3:03 ` Dmitry Torokhov
2009-05-16 8:08 ` Tero Saarni
2009-06-02 15:35 ` Tero Saarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241460369.29685.6.camel@hp \
--to=tero.saarni@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).