* [PATCH 1/1] HID: hiddev, fix lock imbalance
@ 2009-06-19 21:24 Jiri Slaby
2009-06-22 9:01 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2009-06-19 21:24 UTC (permalink / raw)
To: jkosina; +Cc: linux-input, linux-kernel, Jiri Slaby
Add omitted BKL to one switch/case.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
drivers/hid/usbhid/hiddev.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index 9e94215..215b2ad 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -527,8 +527,10 @@ static noinline int hiddev_ioctl_usage(struct hiddev *hiddev, unsigned int cmd,
goto goodreturn;
case HIDIOCGCOLLECTIONINDEX:
+ i = field->usage[uref->usage_index].collection_index;
+ unlock_kernel();
kfree(uref_multi);
- return field->usage[uref->usage_index].collection_index;
+ return i;
case HIDIOCGUSAGES:
for (i = 0; i < uref_multi->num_values; i++)
uref_multi->values[i] =
--
1.6.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-22 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-19 21:24 [PATCH 1/1] HID: hiddev, fix lock imbalance Jiri Slaby
2009-06-22 9:01 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).