* [PATCH] gpio_mouse: use standard driver registration method
@ 2009-06-24 8:31 Saeed Bishara
2009-06-30 2:31 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Saeed Bishara @ 2009-06-24 8:31 UTC (permalink / raw)
To: linux-input; +Cc: saeed.bishara, Saeed Bishara
This patch is needed when the gpio's became available only at late
stages, for example, when using i2c gpio expander.
Signed-off-by: Saeed Bishara <saeed@marvell.com>
---
drivers/input/mouse/gpio_mouse.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c
index 5e5eb88..f468864 100644
--- a/drivers/input/mouse/gpio_mouse.c
+++ b/drivers/input/mouse/gpio_mouse.c
@@ -175,6 +175,7 @@ MODULE_ALIAS("platform:gpio_mouse");
static struct platform_driver gpio_mouse_device_driver = {
.remove = __devexit_p(gpio_mouse_remove),
+ .probe = gpio_mouse_probe,
.driver = {
.name = "gpio_mouse",
.owner = THIS_MODULE,
@@ -183,8 +184,7 @@ static struct platform_driver gpio_mouse_device_driver = {
static int __init gpio_mouse_init(void)
{
- return platform_driver_probe(&gpio_mouse_device_driver,
- gpio_mouse_probe);
+ return platform_driver_register(&gpio_mouse_device_driver);
}
module_init(gpio_mouse_init);
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio_mouse: use standard driver registration method
2009-06-24 8:31 [PATCH] gpio_mouse: use standard driver registration method Saeed Bishara
@ 2009-06-30 2:31 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2009-06-30 2:31 UTC (permalink / raw)
To: Saeed Bishara; +Cc: linux-input, saeed.bishara
Hi Saeed,
On Wed, Jun 24, 2009 at 11:31:39AM +0300, Saeed Bishara wrote:
> This patch is needed when the gpio's became available only at late
> stages, for example, when using i2c gpio expander.
>
When changing from platform_driver_probe() to platform_driver_register()
you also need to convert markings on the driver's probe() method from
__init to __devinit.
Applied.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-30 2:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-24 8:31 [PATCH] gpio_mouse: use standard driver registration method Saeed Bishara
2009-06-30 2:31 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).