Re: [PATCH] PCAP misc input driver (for 2.6.32)

[Daniel Ribeiro <drwyrm@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

Em Dom, 2009-06-28 às 23:14 -0700, Dmitry Torokhov escreveu:
> >  drivers/input/keyboard/Kconfig     |    7 ++
> >  drivers/input/keyboard/Makefile    |    1 +
> >  drivers/input/keyboard/pcap_keys.c |  152 ++++++++++++++++++++++++++++++++++++
> >  3 files changed, 160 insertions(+), 0 deletions(-)
> > 
> 
> First of all I think the driver should live in misc, not in keyboard,
> since it is not a full-fledged keyboard.

Ok.

> > +          Say Y here if you want to use power key and jack events
> > +          on Motorola EZX 2nd generation phones
> > +
> 
> To compile this driver as a module...

Ok.

> > +	case PCAP_IRQ_MIC:
> > +		input_report_key(pcap_keys->input, KEY_HP, !pstat);
> 
> Why not SW_MICROPHONE_INSERT?

Its actually a button.

The device has a single jack for headphone and microphone. And the
headset that we connect to it has a button that you use to answer calls,
or dial.

> > +static int __init pcap_keys_probe(struct platform_device *pdev)
> 
> __devinit, not __init should be used on driver's probe() methods.

Ok.

> > +	pcap_keys->input->name = pdev->name;
> > +	pcap_keys->input->phys = "pcap-keys/input0";
> > +	pcap_keys->input->dev.parent = &pdev->dev;
> 
> I do like a temp for input_dev, it usually makes code a bit smaller.
> Also it would be nice to have but type set (BUS_HOST I think).

Ok.

> > +	set_bit(KEY_HP, pcap_keys->input->keybit);

> __set_bit() please, like Trolok said.

Ok.

> > +static int pcap_keys_remove(struct platform_device *pdev)
> 
> __devexit here.

Ok.

> > +	.remove		= pcap_keys_remove,
> 
> __devexit_p()

Ok.

> > +MODULE_DESCRIPTION("Motorola PCAP2 input events driver");
> > +MODULE_AUTHOR("Ilya Petrov <ilya.muromec@gmail.com>");
> > +MODULE_LICENSE("GPL");
> 
> Do we need MODULE_ALIAS() here?

Do we? I think we don't, but well... It costs nothing. ;)

-- 
Daniel Ribeiro

[-- Attachment #2: Esta é uma parte de mensagem assinada digitalmente --]
[-- Type: application/pgp-signature, Size: 197 bytes --]