linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alberto Panizzo <maramaopercheseimorto@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Lothar Waßmann" <LW@KARO-electronics.de>,
	"H Hartley Sweeten" <hartleys@visionengravers.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Sascha linux-arm" <s.hauer@pengutronix.de>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH v3] input: MXC: add mxc-keypad driver to support the Keypad Port present in the mxc application processors family.
Date: Wed, 27 Jan 2010 13:17:30 +0100	[thread overview]
Message-ID: <1264594650.2463.66.camel@realization> (raw)
In-Reply-To: <20100127104537.GB17421@pengutronix.de>

On mer, 2010-01-27 at 11:45 +0100, Uwe Kleine-König wrote:
> Hallo Alberto,
> 
> On Wed, Jan 27, 2010 at 11:33:04AM +0100, Lothar Waßmann wrote:
> > > +	keypad->clk = clk_get(NULL, "kpp");
> > >
> > clk_get(&pdev->dev, "kpp");
> Maybe even
> 
> 	clk_get(&pdev->dev, NULL);
> 

Mmm.. kpp clock is defined as:
	_REGISTER_CLOCK(NULL, "kpp", kpp_clk)

what you say should work if it would be defined as follow right?
	_REGISTER_CLOCK("mxc_keypad", "kpp", kpp_clk)

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-01-27 12:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27  9:55 [PATCH v3] input: MXC: add mxc-keypad driver to support the Keypad Port present in the mxc application processors family Alberto Panizzo
2010-01-27 10:33 ` Lothar Waßmann
2010-01-27 10:45   ` Uwe Kleine-König
2010-01-27 12:17     ` Alberto Panizzo [this message]
2010-01-27 12:14   ` Alberto Panizzo
2010-01-27 12:18     ` Lothar Waßmann
2010-01-27 14:39       ` Alberto Panizzo
2010-01-27 14:52         ` Lothar Waßmann
2010-01-27 15:29           ` Alberto Panizzo
2010-01-27 17:03             ` Lothar Waßmann
2010-01-27 17:32               ` Dmitry Torokhov
2010-01-27 17:42               ` Alberto Panizzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264594650.2463.66.camel@realization \
    --to=maramaopercheseimorto@gmail.com \
    --cc=LW@KARO-electronics.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hartleys@visionengravers.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).