From: Matthew Garrett <mjg@redhat.com>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com, marcel@holtmann.org,
Matthew Garrett <mjg@redhat.com>
Subject: [PATCH 1/2] input: Add KEY_RFKILL
Date: Tue, 16 Feb 2010 16:36:24 -0500 [thread overview]
Message-ID: <1266356185-10324-1-git-send-email-mjg@redhat.com> (raw)
Most laptops have keys that are intended to toggle all device state, not
just wifi. These are currently generally mapped to KEY_WLAN. As a result,
rfkill will only kill or enable wifi in response to the key press. This
confuses users and can make it difficult for them to enable bluetooth
and wwan devices.
This patch adds a new keycode, KEY_RFKILL. It indicates that the system
should toggle the state of all rfkillable devices.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
include/linux/input.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/input.h b/include/linux/input.h
index 735ceaf..3294a89 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -594,7 +594,7 @@ struct input_absinfo {
#define KEY_NUMERIC_9 0x209
#define KEY_NUMERIC_STAR 0x20a
#define KEY_NUMERIC_POUND 0x20b
-
+#define KEY_RFKILL 0x20c /* Key that controls all radios */
#define KEY_CAMERA_FOCUS 0x210
/* We avoid low common keys in module aliases so they don't get huge. */
--
1.6.6.1
next reply other threads:[~2010-02-16 21:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 21:36 Matthew Garrett [this message]
[not found] ` <1266356185-10324-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-02-16 21:36 ` [PATCH 2/2] rfkill: Add support for KEY_RFKILL Matthew Garrett
2010-02-16 23:04 ` Marcel Holtmann
2010-02-16 23:05 ` [PATCH 1/2] input: Add KEY_RFKILL Marcel Holtmann
2010-02-17 5:22 ` Dmitry Torokhov
[not found] ` <20100217052247.GD7160-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-02-17 18:03 ` Matthew Garrett
2010-02-17 18:43 ` Christian Lamparter
[not found] ` <22ee4e771002171043u2aaf97vd73c1090c2fce901-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 18:45 ` Matthew Garrett
2010-02-17 18:49 ` Bastien Nocera
[not found] ` <1266432575.678.980.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-02-17 22:34 ` Peter Hutterer
2010-02-18 4:16 ` Dmitry Torokhov
[not found] ` <20100218041636.GA19037-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-02-18 4:29 ` Peter Hutterer
2010-02-17 19:18 ` Christian Lamparter
2010-02-17 19:17 ` Dmitry Torokhov
[not found] ` <20100217191708.GA15554-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-02-17 19:42 ` Christian Lamparter
2010-02-17 19:54 ` Dmitry Torokhov
2010-02-17 20:02 ` Matthew Garrett
2010-02-17 20:49 ` Dmitry Torokhov
[not found] ` <446821D4-8E9D-4701-9A50-04738C5733B6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-17 20:50 ` Matthew Garrett
2010-02-17 20:18 ` Christian Lamparter
[not found] ` <22ee4e771002171218t69cc4348ia0300a645ce9763d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 20:52 ` Dmitry Torokhov
[not found] ` <069C4DAE-598D-45F1-99B5-DA5BAF718179-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-17 21:12 ` pat-lkml-Jx9fsTfDDR3YtjvyW6yDsg
2010-02-17 21:28 ` Christian Lamparter
[not found] ` <22ee4e771002171328w3c9cbb8n663c291e9d3634e5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 21:40 ` Dmitry Torokhov
2010-02-17 22:03 ` Christian Lamparter
[not found] ` <22ee4e771002171403o6f0b99e8qd683d78e74fe4522-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-20 9:18 ` Dmitry Torokhov
2010-02-19 14:33 ` Henrique de Moraes Holschuh
2010-02-17 19:18 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2009-09-10 17:21 Matthew Garrett
[not found] ` <1252603292-20830-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-09-10 17:27 ` Luis R. Rodriguez
[not found] ` <43e72e890909101027saf1ed35u23936729eccf3f92-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-09-10 17:31 ` Matthew Garrett
2009-09-11 5:13 ` Dmitry Torokhov
[not found] ` <20090911051259.GC23210-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2009-11-13 5:34 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266356185-10324-1-git-send-email-mjg@redhat.com \
--to=mjg@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).