From: Vasily Khoruzhick <anarsoul@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: ben-linux@fluff.org, linux-input@vger.kernel.org,
Vasily Khoruzhick <anarsoul@gmail.com>
Subject: [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down
Date: Thu, 18 Feb 2010 18:32:28 +0200 [thread overview]
Message-ID: <1266510750-9846-3-git-send-email-anarsoul@gmail.com> (raw)
In-Reply-To: <1266510750-9846-1-git-send-email-anarsoul@gmail.com>
By default, driver reports touches when it gots (1 << ts.shift)
samples, even if stylus is up. This behavior looks wrong to me.
Patch makes driver to report touches only when stylus is down.
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
drivers/input/touchscreen/s3c2410_ts.c | 22 +++++++++++-----------
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
index 6386b44..e2fe2ed 100644
--- a/drivers/input/touchscreen/s3c2410_ts.c
+++ b/drivers/input/touchscreen/s3c2410_ts.c
@@ -128,25 +128,25 @@ static void touch_timer_fire(unsigned long data)
down = get_down(data0, data1);
- if (ts.count == (1 << ts.shift)) {
- ts.xp >>= ts.shift;
- ts.yp >>= ts.shift;
+ if (down) {
+ if (ts.count == (1 << ts.shift)) {
+ ts.xp >>= ts.shift;
+ ts.yp >>= ts.shift;
- dev_dbg(ts.dev, "%s: X=%lu, Y=%lu, count=%d\n",
- __func__, ts.xp, ts.yp, ts.count);
+ dev_dbg(ts.dev, "%s: X=%lu, Y=%lu, count=%d\n",
+ __func__, ts.xp, ts.yp, ts.count);
- input_report_abs(ts.input, ABS_X, ts.xp);
- input_report_abs(ts.input, ABS_Y, ts.yp);
+ input_report_abs(ts.input, ABS_X, ts.xp);
+ input_report_abs(ts.input, ABS_Y, ts.yp);
- input_report_key(ts.input, BTN_TOUCH, 1);
- input_sync(ts.input);
+ input_report_key(ts.input, BTN_TOUCH, 1);
+ input_sync(ts.input);
+ }
ts.xp = 0;
ts.yp = 0;
ts.count = 0;
- }
- if (down) {
s3c_adc_start(ts.client, 0, 1 << ts.shift);
} else {
ts.count = 0;
--
1.7.0
next prev parent reply other threads:[~2010-02-18 16:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 16:32 [PATCH 0/4] s3c24xx_ts driver fixes Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 1/4] Add resources description for s3c24xx ts driver Vasily Khoruzhick
2010-02-18 16:32 ` Vasily Khoruzhick [this message]
2010-02-19 9:17 ` [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down Dmitry Torokhov
2010-02-19 10:02 ` Vasily Khoruzhick
2010-02-21 7:35 ` Dmitry Torokhov
2010-02-21 9:05 ` Vasily Khoruzhick
2010-02-21 9:41 ` Dmitry Torokhov
2010-02-21 10:10 ` Vasily Khoruzhick
2010-02-21 10:28 ` Dmitry Torokhov
2010-02-21 10:33 ` Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 3/4] s3c24xx_adc: disable/enable IRQ on suspend/resume Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 4/4] s3c24xx_ts: re-enable IRQ on resume Vasily Khoruzhick
2010-02-19 9:05 ` Dmitry Torokhov
[not found] ` <201002212344.39633.anarsoul@gmail.com>
[not found] ` <20100221225125.GA18604@core.coreip.homeip.net>
[not found] ` <201002220058.52583.anarsoul@gmail.com>
2010-02-22 7:14 ` [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down Dmitry Torokhov
2010-02-22 8:58 ` Vasily Khoruzhick
2010-02-22 9:03 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266510750-9846-3-git-send-email-anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).