From: Benjamin Tissoires <tissoire@cena.fr>
To: linux-input@vger.kernel.org
Subject: [PATCH 3/3] HID: deletion of unused code in hid-magicmouse.
Date: Mon, 08 Mar 2010 22:29:47 +0100 [thread overview]
Message-ID: <1268083787.9018.21.camel@localhost.localdomain> (raw)
This code, related to the second input device, is unnecessary as it concerns
the previous implementation and is not used anymore.
Signed-off-by: Benjamin Tissoires <tissoire@cena.fr>
---
drivers/hid/hid-magicmouse.c | 68 ------------------------------------------
1 files changed, 0 insertions(+), 68 deletions(-)
diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
index 32d90c8..b9d605e 100644
--- a/drivers/hid/hid-magicmouse.c
+++ b/drivers/hid/hid-magicmouse.c
@@ -262,74 +262,6 @@ static int magicmouse_raw_event(struct hid_device *hdev,
return 1;
}
-static int magicmouse_input_open(struct input_dev *dev)
-{
- struct hid_device *hid = input_get_drvdata(dev);
-
- return hid->ll_driver->open(hid);
-}
-
-static void magicmouse_input_close(struct input_dev *dev)
-{
- struct hid_device *hid = input_get_drvdata(dev);
-
- hid->ll_driver->close(hid);
-}
-
-static void magicmouse_setup_input(struct input_dev *input, struct hid_device *hdev)
-{
- input_set_drvdata(input, hdev);
- input->event = hdev->ll_driver->hidinput_input_event;
- input->open = magicmouse_input_open;
- input->close = magicmouse_input_close;
-
- input->name = hdev->name;
- input->phys = hdev->phys;
- input->uniq = hdev->uniq;
- input->id.bustype = hdev->bus;
- input->id.vendor = hdev->vendor;
- input->id.product = hdev->product;
- input->id.version = hdev->version;
- input->dev.parent = hdev->dev.parent;
-
- __set_bit(EV_KEY, input->evbit);
- __set_bit(BTN_LEFT, input->keybit);
- __set_bit(BTN_RIGHT, input->keybit);
- if (emulate_3button)
- __set_bit(BTN_MIDDLE, input->keybit);
- __set_bit(BTN_TOOL_FINGER, input->keybit);
-
- __set_bit(EV_REL, input->evbit);
- __set_bit(REL_X, input->relbit);
- __set_bit(REL_Y, input->relbit);
- if (emulate_scroll_wheel)
- __set_bit(REL_WHEEL, input->relbit);
-
- if (report_touches) {
- __set_bit(EV_ABS, input->evbit);
-
- input_set_abs_params(input, ABS_MT_TRACKING_ID, 0, 15, 0, 0);
- input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0, 255, 4, 0);
- input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0, 255, 4, 0);
- input_set_abs_params(input, ABS_MT_ORIENTATION, -32, 31, 1, 0);
- input_set_abs_params(input, ABS_MT_POSITION_X, -1100, 1358,
- 4, 0);
- /* Note: Touch Y position from the device is inverted relative
- * to how pointer motion is reported (and relative to how USB
- * HID recommends the coordinates work). This driver keeps
- * the origin at the same position, and just uses the additive
- * inverse of the reported Y.
- */
- input_set_abs_params(input, ABS_MT_POSITION_Y, -1589, 2047,
- 4, 0);
- }
-
- if (report_undeciphered) {
- __set_bit(EV_MSC, input->evbit);
- __set_bit(MSC_RAW, input->mscbit);
- }
-}
-
static int magicmouse_input_mapping(struct hid_device *hdev, struct hid_input *hinput,
struct hid_field *field, struct hid_usage *usage,
unsigned long **bit, int *max)
-- 1.6.6.1
next reply other threads:[~2010-03-08 21:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 21:29 Benjamin Tissoires [this message]
[not found] <1268065277-30129-1-git-send-email-tissoire@cena.fr>
[not found] ` <1268065277-30129-2-git-send-email-tissoire@cena.fr>
[not found] ` <1268065277-30129-3-git-send-email-tissoire@cena.fr>
[not found] ` <1268065277-30129-4-git-send-email-tissoire@cena.fr>
[not found] ` <1268065277-30129-5-git-send-email-tissoire@cena.fr>
2010-03-08 16:27 ` [PATCH 3/3] HID: deletion of unused code in hid-magicmouse Benjamin Tissoires
2010-03-08 16:30 ` Jiri Kosina
2010-03-08 16:57 ` Benjamin Tissoires
2010-03-08 20:27 ` Michael Poole
2010-03-08 20:51 ` Benjamin Tissoires
2010-03-08 23:56 ` Jiri Kosina
2010-03-09 12:00 ` Rantanplan
2010-03-10 15:09 ` Jiri Kosina
2010-03-10 15:39 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268083787.9018.21.camel@localhost.localdomain \
--to=tissoire@cena.fr \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).