From: Christoph Fritz <chf.fritz@googlemail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Peter M. Petrakis" <peter.petrakis@canonical.com>,
linux-input@vger.kernel.org, rubini <rubini@cvml.unipv.it>
Subject: Re: [PATCH] Reset ps/2 port should psmouse_probe fail before retrying
Date: Sat, 24 Apr 2010 03:22:05 +0200 [thread overview]
Message-ID: <1272072125.4341.10.camel@lovely> (raw)
In-Reply-To: <201004230953.52447.dmitry.torokhov@gmail.com>
On Fri, 2010-04-23 at 09:53 -0700, Dmitry Torokhov wrote:
> On Thursday 22 April 2010 05:47:48 pm Christoph Fritz wrote:
> > in conclusion:
> > If a Synaptics touchpad can't be initialized (synaptics_init) and falls
> > back to PS/2, it doesn't get a psmouse_reset() after resuming from
> > suspend as it would get with a synaptics driver.
>
> Yes, you are right. Maybe we should just reset psmouse unconditionally in
> psmouse_reconnect() before actually doing any protocol reconnect/reprobe. That
> should help in cases when users not enable Synaptics support; also it is
> probably unlikely that mouse that was there gets unplugged after resume.
Yes, this would solve that case too. Maybe if we take that
"unconditionally-reset-step", what about taking the full step and
getting rid of the whole i8042_dmi_reset_table quirk stuff and doing
unconditionally resets there too?
next prev parent reply other threads:[~2010-04-24 1:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 22:52 [PATCH] Reset ps/2 port should psmouse_probe fail before retrying Peter M. Petrakis
2010-04-17 11:01 ` Christoph Fritz
2010-04-17 15:31 ` Peter M. Petrakis
2010-04-17 16:53 ` Christoph Fritz
2010-04-19 15:33 ` Peter M. Petrakis
2010-04-20 0:37 ` Christoph Fritz
2010-04-20 21:08 ` Peter M. Petrakis
2010-04-21 6:33 ` Dmitry Torokhov
2010-04-21 16:05 ` Peter M. Petrakis
2010-04-21 17:10 ` Dmitry Torokhov
2010-04-21 19:38 ` Peter M. Petrakis
2010-04-21 19:52 ` Dmitry Torokhov
2010-04-21 21:10 ` Peter M. Petrakis
2010-04-22 16:28 ` Christoph Fritz
2010-04-22 21:48 ` Peter M. Petrakis
2010-04-22 21:55 ` Dmitry Torokhov
2010-04-23 0:47 ` Christoph Fritz
2010-04-23 16:53 ` Dmitry Torokhov
2010-04-23 18:46 ` Peter M. Petrakis
2010-04-28 17:07 ` Dmitry Torokhov
2010-04-28 20:17 ` Peter M. Petrakis
2010-04-29 16:57 ` Christoph Fritz
2010-04-29 17:46 ` Dmitry Torokhov
2010-04-30 22:37 ` Peter M. Petrakis
2010-05-02 3:07 ` Christoph Fritz
2010-05-02 7:41 ` Christoph Fritz
2010-05-07 17:57 ` Peter M. Petrakis
2010-05-08 16:01 ` Christoph Fritz
2010-04-24 1:22 ` Christoph Fritz [this message]
2010-04-24 10:00 ` Christoph Fritz
2010-04-28 7:26 ` Dmitry Torokhov
2010-05-08 16:22 ` Christoph Fritz
2010-05-11 8:22 ` Dmitry Torokhov
2010-05-11 22:24 ` Christoph Fritz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272072125.4341.10.camel@lovely \
--to=chf.fritz@googlemail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=peter.petrakis@canonical.com \
--cc=rubini@cvml.unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).