Re: [PATCH] hid/hid-sony: fix sony_set_operational_bt

Re: [PATCH] hid/hid-sony: fix sony_set_operational_bt

[Bastien Nocera]

On Thu, 2010-04-29 at 23:59 +0200, Antonio Ospite wrote:
> Don't send the report type as part of the data, this prevents the
> controller from going into the operational state at all.
> 
> This is completely equivalent to what the code originally meant to accomplish:
> as per in net/bluetooth/hidp/core.c::hidp_output_raw_report(), by using
> HID_FEATURE_REPORT here, what will be actually sent is
> (HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE) which is exactly 0x53.
> 
> Signed-off-by: Antonio Ospite <ospite-aNJ+ML1ZbiP93QAQaVx+gl6hYfS7NtTn@public.gmane.org>

My mistake there. I should have tested the patch at run-time, and not
trusted my copy-paste skills :(

Signed-off-by: Bastien Nocera <hadess-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>

Re: [PATCH] hid/hid-sony: fix sony_set_operational_bt

[Jiri Kosina]

On Fri, 30 Apr 2010, Bastien Nocera wrote:

> > Don't send the report type as part of the data, this prevents the
> > controller from going into the operational state at all.
> > 
> > This is completely equivalent to what the code originally meant to accomplish:
> > as per in net/bluetooth/hidp/core.c::hidp_output_raw_report(), by using
> > HID_FEATURE_REPORT here, what will be actually sent is
> > (HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE) which is exactly 0x53.
> > 
> > Signed-off-by: Antonio Ospite <ospite-aNJ+ML1ZbiP93QAQaVx+gl6hYfS7NtTn@public.gmane.org>
> Signed-off-by: Bastien Nocera <hadess-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

[PATCH] hid/hid-sony: fix sony_set_operational_bt

[Antonio Ospite]

Don't send the report type as part of the data, this prevents the
controller from going into the operational state at all.

This is completely equivalent to what the code originally meant to accomplish:
as per in net/bluetooth/hidp/core.c::hidp_output_raw_report(), by using
HID_FEATURE_REPORT here, what will be actually sent is
(HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE) which is exactly 0x53.

Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---

As this change makes sony_set_operational_bt work while it was non working
before, it might be good to have it in 2.6.34.

Thanks,
   Antonio Ospite
   http://ao2.it

 drivers/hid/hid-sony.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 7502a4b..402d557 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -76,7 +76,7 @@ static int sony_set_operational_usb(struct hid_device *hdev)
 
 static int sony_set_operational_bt(struct hid_device *hdev)
 {
-	unsigned char buf[] = { 0x53, 0xf4,  0x42, 0x03, 0x00, 0x00 };
+	unsigned char buf[] = { 0xf4,  0x42, 0x03, 0x00, 0x00 };
 	return hdev->hid_output_raw_report(hdev, buf, sizeof(buf), HID_FEATURE_REPORT);
 }
 
-- 
1.7.1