From: Antonio Ospite <ospite@studenti.unina.it>
To: linux-input@vger.kernel.org
Cc: Antonio Ospite <ospite@studenti.unina.it>,
cbe-oss-dev@lists.ozlabs.org, linux-bluetooth@vger.kernel.org,
hadess@hadess.net
Subject: [PATCH] hid/hid-sony: fix sony_set_operational_bt
Date: Fri, 30 Apr 2010 21:53:59 +0200 [thread overview]
Message-ID: <1272657239-29436-1-git-send-email-ospite@studenti.unina.it> (raw)
Don't send the report type as part of the data, this prevents the
controller from going into the operational state at all.
This is completely equivalent to what the code originally meant to accomplish:
as per in net/bluetooth/hidp/core.c::hidp_output_raw_report(), by using
HID_FEATURE_REPORT here, what will be actually sent is
(HIDP_TRANS_SET_REPORT | HIDP_DATA_RTYPE_FEATURE) which is exactly 0x53.
Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
As this change makes sony_set_operational_bt work while it was non working
before, it might be good to have it in 2.6.34.
Thanks,
Antonio Ospite
http://ao2.it
drivers/hid/hid-sony.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 7502a4b..402d557 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -76,7 +76,7 @@ static int sony_set_operational_usb(struct hid_device *hdev)
static int sony_set_operational_bt(struct hid_device *hdev)
{
- unsigned char buf[] = { 0x53, 0xf4, 0x42, 0x03, 0x00, 0x00 };
+ unsigned char buf[] = { 0xf4, 0x42, 0x03, 0x00, 0x00 };
return hdev->hid_output_raw_report(hdev, buf, sizeof(buf), HID_FEATURE_REPORT);
}
--
1.7.1
next reply other threads:[~2010-04-30 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 19:53 Antonio Ospite [this message]
[not found] <1272578374-9250-1-git-send-email-ospite@studenti.unina.it>
[not found] ` <1272578374-9250-1-git-send-email-ospite-aNJ+ML1ZbiP93QAQaVx+gl6hYfS7NtTn@public.gmane.org>
2010-04-29 23:23 ` [PATCH] hid/hid-sony: fix sony_set_operational_bt Bastien Nocera
[not found] ` <1272583410.2582.441.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-05-03 15:19 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272657239-29436-1-git-send-email-ospite@studenti.unina.it \
--to=ospite@studenti.unina.it \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).