From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Oskar Schirmer" Subject: [PATCH v2] ad7877: fix spi word size to 16 bit Date: Tue, 18 May 2010 10:34:13 +0200 Message-ID: <1274171653-8152-1-git-send-email-os@emlix.com> References: <1273142265-11929-1-git-send-email-os@emlix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx1.emlix.com ([193.175.82.87]:55531 "EHLO mx1.emlix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754101Ab0ERIeZ (ORCPT ); Tue, 18 May 2010 04:34:25 -0400 In-Reply-To: <1273142265-11929-1-git-send-email-os@emlix.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Mike Frysinger , Andrew Morton , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Hennerich , H Hartley Sweeten , Oskar Schirmer , =?utf-8?q?Daniel=20Gl=C3=B6ckner?= , Oliver Schneidewind With no word size given in the users platform data, a generic spi host controller driver will assume a default word size of eight bit. This causes transmission to be performed bytewise, which will fail on little endian machines for sure. Failure on big endian depends on usage of slave select to mark word boundaries. Anyway, ad7877 is specified to work with 16 bit per word, so unconditionally set the word size accordingly. =46lag an error where 16 bit per word is not available. Signed-off-by: Oskar Schirmer Signed-off-by: Daniel Gl=C3=B6ckner Signed-off-by: Oliver Schneidewind --- drivers/input/touchscreen/ad7877.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) v2: check return value for spi_setup failure diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchsc= reen/ad7877.c index 698d6e7..eebde5b 100644 --- a/drivers/input/touchscreen/ad7877.c +++ b/drivers/input/touchscreen/ad7877.c @@ -680,6 +680,13 @@ static int __devinit ad7877_probe(struct spi_devic= e *spi) return -EINVAL; } =20 + spi->bits_per_word =3D 16; + err =3D spi_setup(spi); + if (err) { + dev_dbg(&spi->dev, "spi master doesn't support 16 bits/word\n"); + return err; + } + ts =3D kzalloc(sizeof(struct ad7877), GFP_KERNEL); input_dev =3D input_allocate_device(); if (!ts || !input_dev) { --=20 1.5.3.7 -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html