From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH v3] powerpc: Add i8042 keyboard and mouse irq parsing Date: Sat, 29 May 2010 13:35:53 +1000 Message-ID: <1275104153.1931.522.camel@pasglop> References: <20100525080834.29149.70967.stgit@ES-J7S4D2J.amer.consind.ge.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: Martyn Welch , linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, devicetree-discuss , Dmitry Torokhov , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-input@vger.kernel.org > The patch looks okay to me. > > BTW, where is the i8042 binding documented? Ben, is this location of > the kbd/mouse irq historical, or is it just something that we happened > to get when the .dts files were first created? Having the irq > specified directly in the kbd or aux nodes would make a lot more > sense, and if this isn't something already nailed down, then it > probably does make sense to move the irq specification, fall back to > the parent node to still support older trees, and with the hard coded > irq numbers as the last resort. That's just ISA crap. It should be in the existing OF bindings. Cheers, Ben.