From: Thomas Weber <weber@corscience.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Thomas Weber <weber@corscience.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Input: ads7846: Fix warning about output format
Date: Wed, 2 Jun 2010 08:50:29 +0200 [thread overview]
Message-ID: <1275461429-4838-1-git-send-email-weber@corscience.de> (raw)
This patch fixes a compiler warning about wrong output format.
drivers/input/touchscreen/ads7846.c: In function 'ads7846_probe':
drivers/input/touchscreen/ads7846.c:1167: warning: format '%ld' expects
type 'long int', but argument 4 has type 'int'
Introduced by commit 067fb2f648543894ce775082c5636f4c32b99e4f ("Input:
ads7846 - return error on regulator_get() failure").
The ERR_PTR returns a long so the variable err needs to be long.
Signed-off-by: Thomas Weber <weber@corscience.de>
---
drivers/input/touchscreen/ads7846.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 634f6f6..9ba7d2e 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -885,7 +885,7 @@ static int __devinit ads7846_probe(struct spi_device *spi)
struct spi_message *m;
struct spi_transfer *x;
int vref;
- int err;
+ long err;
if (!spi->irq) {
dev_dbg(&spi->dev, "no IRQ?\n");
@@ -1170,7 +1170,7 @@ static int __devinit ads7846_probe(struct spi_device *spi)
err = regulator_enable(ts->reg);
if (err) {
- dev_err(&spi->dev, "unable to enable regulator: %d\n", err);
+ dev_err(&spi->dev, "unable to enable regulator: %ld\n", err);
goto err_put_regulator;
}
--
1.7.1
next reply other threads:[~2010-06-02 6:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 6:50 Thomas Weber [this message]
2010-06-02 7:39 ` [PATCH] Input: ads7846: Fix warning about output format Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275461429-4838-1-git-send-email-weber@corscience.de \
--to=weber@corscience.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).