linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chase Douglas <chase.douglas@canonical.com>
To: linux-input@vger.kernel.org
Subject: [PATCH 1/4] HID: magicmouse: scroll on entire surface, not just middle of mouse
Date: Wed,  2 Jun 2010 10:28:25 -0400	[thread overview]
Message-ID: <1275488908-23624-2-git-send-email-chase.douglas@canonical.com> (raw)
In-Reply-To: <1275488908-23624-1-git-send-email-chase.douglas@canonical.com>

Previously, scroll events only occurred when the user moved a touch
along the middle of the touch surface. This is unintuitive for a normal
user who is not aware of this. The device has a uniform surface, so the
distinction is artificial. This change removes the touch area check for
a scroll event, which replicates the OS X behavior.

Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
 drivers/hid/hid-magicmouse.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
index f10d56a..cd70635 100644
--- a/drivers/hid/hid-magicmouse.c
+++ b/drivers/hid/hid-magicmouse.c
@@ -160,10 +160,9 @@ static void magicmouse_emit_touch(struct magicmouse_sc *msc, int raw_id, u8 *tda
 	msc->touches[id].size = misc & 63;
 
 	/* If requested, emulate a scroll wheel by detecting small
-	 * vertical touch motions along the middle of the mouse.
+	 * vertical touch motions.
 	 */
-	if (emulate_scroll_wheel &&
-	    middle_button_start < x && x < middle_button_stop) {
+	if (emulate_scroll_wheel) {
 		static const int accel_profile[] = {
 			256, 228, 192, 160, 128, 96, 64, 32,
 		};
-- 
1.7.0.4


  reply	other threads:[~2010-06-02 14:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-02 14:28 [PATCH 0/4] HID: magicmouse: improve scrolling Chase Douglas
2010-06-02 14:28 ` Chase Douglas [this message]
2010-06-02 14:28 ` [PATCH 2/4] HID: magicmouse: properly account for scroll movement in state Chase Douglas
2010-06-10  1:25   ` Michael Poole
2010-06-16 15:03     ` Chase Douglas
2010-06-16 15:05       ` Jiri Kosina
2010-06-02 14:28 ` [PATCH 3/4] HID: magicmouse: disable and add module param for scroll acceleration Chase Douglas
2010-06-02 14:28 ` [PATCH 4/4] HID: magicmouse: add param for scroll speed Chase Douglas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275488908-23624-2-git-send-email-chase.douglas@canonical.com \
    --to=chase.douglas@canonical.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).