Re: [PATCH 0/3] input: evdev: Dynamic buffers (rev4)

[Chase Douglas <chase.douglas@canonical.com>]

On Sat, 2010-06-05 at 13:04 +0200, Henrik Rydberg wrote:
> Dmitry,
> 
> Please find enclosed the fourth version of the evdev buffer patches.
> 
> This version implements buffer locking using event_lock as you
> suggested, such that we can proceed with fixing the evdev buffer
> problem independently from providing a suitable one-to-many buffer.
> 
> The first patch converts the per-client buffers to a common buffer,
> and adds a fixme since the code is expected to be further
> improved. The second and third patch includes your review comments.
> 
> Thanks,
> Henrik
> 
> ---
> 
> Henrik Rydberg (3):
>   input: evdev: Use multi-reader buffer to save space (rev4)
>   input: evdev: Convert to dynamic event buffer (rev4)
>   input: Use driver hint to compute the evdev buffer size (rev2)
> 
>  drivers/input/evdev.c |   68 +++++++++++++++++++++++++++++++++----------------
>  include/linux/input.h |   17 ++++++++++++
>  2 files changed, 63 insertions(+), 22 deletions(-)

I like the first patch for the simplification of buffer management into
one buffer per device, and I think it may be more efficient due to there
being less locking when syncing the clients.

The second and third patches seem like reasonable solutions to the
buffers being too small for some devices that can handle many MT events
simultaneously and offer many attributes per event.

Acked-by: Chase Douglas <chase.douglas@canonical.com>