From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luotao Fu Subject: [PATCH 2/6] gpio/stmpe-gpio: fix set direction input Date: Thu, 24 Jun 2010 13:13:37 +0200 Message-ID: <1277378021-16802-3-git-send-email-l.fu@pengutronix.de> References: <20100622135635.GA30720@bnru02.bnr.st.com> Return-path: In-Reply-To: <20100622135635.GA30720@bnru02.bnr.st.com> Sender: linux-kernel-owner@vger.kernel.org To: Rabin VINCENT , Samuel Ortiz , Dmitry Torokhov Cc: Linus WALLEIJ , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, STEricsson_nomadik_linux , Luotao Fu List-Id: linux-input@vger.kernel.org to set an GPIO pin to input, the corresponding bit in GPDR needs to be cleared instead of set. fixed with this patch. Signed-off-by: Luotao Fu --- drivers/gpio/stmpe-gpio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/stmpe-gpio.c b/drivers/gpio/stmpe-gpio.c index a4de271..4e1f1b9 100644 --- a/drivers/gpio/stmpe-gpio.c +++ b/drivers/gpio/stmpe-gpio.c @@ -88,7 +88,7 @@ static int stmpe_gpio_direction_input(struct gpio_chip *chip, u8 reg = stmpe->regs[STMPE_IDX_GPDR_LSB] - (offset / 8); u8 mask = 1 << (offset % 8); - return stmpe_set_bits(stmpe, reg, mask, mask); + return stmpe_set_bits(stmpe, reg, mask, 0); } static int stmpe_gpio_to_irq(struct gpio_chip *chip, unsigned offset) -- 1.7.1