From: chris@cnpbagwell.com
To: linux-input@vger.kernel.org
Cc: Chris Bagwell <chris@cnpbagwell.com>
Subject: [PATCH 2/2] input: synaptics - set min/max for finger width
Date: Sun, 18 Jul 2010 14:06:07 -0500 [thread overview]
Message-ID: <1279479967-4499-2-git-send-email-chris@cnpbagwell.com> (raw)
In-Reply-To: <1279479967-4499-1-git-send-email-chris@cnpbagwell.com>
From: Chris Bagwell <chris@cnpbagwell.com>
Reporting this will allow GUI config apps to correctly scale
width sensitive config values (such as palm detect) to correct range.
Current user apps are detecting kernels min/max=0/0 and making
an assumption that it means 0/16 or 0/15.
Synaptics touchpad interface guides show 4/15 are correct values
but driver forces to 0 when no fingers on touchpad.
Signed-off-by: Chris Bagwell <chris@cnpbagwell.com>
---
drivers/input/mouse/synaptics.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 1b49d7f..85a1e14 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -600,7 +600,7 @@ static void set_input_params(struct input_dev *dev, struct synaptics_data *priv)
input_set_abs_params(dev, ABS_PRESSURE, 0, 255, 0, 0);
if (SYN_CAP_PALMDETECT(priv->capabilities))
- __set_bit(ABS_TOOL_WIDTH, dev->absbit);
+ input_set_abs_params(dev, ABS_TOOL_WIDTH, 0, 15, 0, 0);
__set_bit(EV_KEY, dev->evbit);
__set_bit(BTN_TOUCH, dev->keybit);
--
1.7.1.1
next prev parent reply other threads:[~2010-07-18 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-18 19:06 [PATCH 1/2] input: synaptics - only report width on hardware that supports it chris
2010-07-18 19:06 ` chris [this message]
2010-07-19 16:07 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279479967-4499-2-git-send-email-chris@cnpbagwell.com \
--to=chris@cnpbagwell.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).