From: Artem Bityutskiy <dedekind1@gmail.com>
To: ext-phil.2.carmody@nokia.com
Cc: dmitry.torokhov@gmail.com, daniel@caiaq.de,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: RE: [PATCH 4/4] input: dynamically allocate ABS information
Date: Wed, 21 Jul 2010 13:42:48 +0300 [thread overview]
Message-ID: <1279708968.2306.11.camel@localhost> (raw)
In-Reply-To: <702744BC498BAE41B3AA631D95EC463058B3CFD798@NOK-EUMSG-01.mgdnok.nokia.com>
On Wed, 2010-07-21 at 11:22 +0200, ext-phil.2.carmody@nokia.com wrote:
> A tiny tiny nit...
>
> From: Dmitry Torokhov [dmitry.torokhov@gmail.com]
> ...
> +void input_alloc_absinfo(struct input_dev *dev)
> +{
> + if (!dev->absinfo)
> + dev->absinfo = kcalloc(ABS_CNT, sizeof(struct input_absinfo),
> + GFP_KERNEL);
> +
> + WARN(!dev->absinfo, "%s(): kzalloc() failed?\n", __func__);
>
> kcalloc failed, not kzalloc.
kmalloc and friends already print a warning with a stack dump when they
fail, unless this is overrided with __GFP_NOWARN, which is not the case
here. So in usually we do not print messages/warnigns when we fail to
allocate.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-07-21 10:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 17:22 [RFC] linux-input: dynamically allocate ABS axis information Daniel Mack
2010-05-19 17:22 ` [PATCH 1/4] input: use ABS_CNT rather than (ABS_MAX + 1) Daniel Mack
2010-05-19 17:22 ` [PATCH 2/4] input: add static inline helpers for ABS properties Daniel Mack
2010-05-19 17:22 ` [PATCH 3/4] input: switch to input_abs_*() access functions Daniel Mack
2010-07-14 8:09 ` Dmitry Torokhov
2010-05-19 17:22 ` [PATCH 4/4] input: dynamically allocate ABS information Daniel Mack
2010-05-24 16:08 ` Daniel Mack
2010-05-24 16:15 ` Dmitry Torokhov
2010-06-16 8:39 ` Daniel Mack
2010-07-21 8:30 ` Dmitry Torokhov
2010-07-21 8:31 ` Dmitry Torokhov
2010-07-21 8:32 ` Dmitry Torokhov
2010-07-21 9:22 ` ext-phil.2.carmody
2010-07-21 10:42 ` Artem Bityutskiy [this message]
2010-08-11 7:02 ` Daniel Mack
2010-08-13 3:35 ` Dmitry Torokhov
2010-08-07 15:23 ` Daniel Mack
2010-08-11 3:29 ` Dmitry Torokhov
2010-07-14 8:18 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279708968.2306.11.camel@localhost \
--to=dedekind1@gmail.com \
--cc=daniel@caiaq.de \
--cc=dmitry.torokhov@gmail.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).