From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Levitsky Subject: Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver Date: Thu, 29 Jul 2010 19:26:15 +0300 Message-ID: <1280420775.32069.5.camel@maxim-laptop> References: <1280414519.29938.53.camel@maxim-laptop> <1280417934.15757.20.camel@morgan.silverblock.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1280417934.15757.20.camel@morgan.silverblock.net> Sender: linux-media-owner@vger.kernel.org To: Andy Walls Cc: Christoph Bartelmus , jarod@wilsonet.com, linux-input@vger.kernel.org, linux-media@vger.kernel.org, lirc-list@lists.sourceforge.net, mchehab@redhat.com List-Id: linux-input@vger.kernel.org On Thu, 2010-07-29 at 11:38 -0400, Andy Walls wrote: > On Thu, 2010-07-29 at 17:41 +0300, Maxim Levitsky wrote: > > On Thu, 2010-07-29 at 09:23 +0200, Christoph Bartelmus wrote: > > > Hi Maxim, > > > > > > on 29 Jul 10 at 02:40, Maxim Levitsky wrote: > > > [...] > > > > In addition to comments, I changed helper function that processes samples > > > > so it sends last space as soon as timeout is reached. > > > > This breaks somewhat lirc, because now it gets 2 spaces in row. > > > > However, if it uses timeout reports (which are now fully supported) > > > > it will get such report in middle. > > > > > > > > Note that I send timeout report with zero value. > > > > I don't think that this value is importaint. > > > > > > This does not sound good. Of course the value is important to userspace > > > and 2 spaces in a row will break decoding. > > > > > > Christoph > > > > Could you explain exactly how timeout reports work? > > > > Lirc interface isn't set to stone, so how about a reasonable compromise. > > After reasonable long period of inactivity (200 ms for example), space > > is sent, and then next report starts with a pulse. > > So gaps between keypresses will be maximum of 200 ms, and as a bonus I > > could rip of the logic that deals with remembering the time? > > > > Best regards, > > Maxim Levitsky So, timeout report is just another sample, with a mark attached, that this is last sample? right? Christoph, right? In that case, lets do that this way: As soon as timeout is reached, I just send lirc the timeout report. Then next keypress will start with pulse. I think this is the best solution. Best regards, Maxim Levitsky