From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Walls Subject: Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it. Date: Thu, 29 Jul 2010 23:46:05 -0400 Message-ID: <1280461565.15737.124.camel@localhost> References: <1280456235-2024-1-git-send-email-maximlevitsky@gmail.com> <1280456235-2024-14-git-send-email-maximlevitsky@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from proofpoint-cluster.metrocast.net ([65.175.128.136]:50427 "EHLO proofpoint-cluster.metrocast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755806Ab0G3Dpp (ORCPT ); Thu, 29 Jul 2010 23:45:45 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jon Smirl Cc: Maxim Levitsky , lirc-list@lists.sourceforge.net, Jarod Wilson , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab , Christoph Bartelmus On Thu, 2010-07-29 at 22:39 -0400, Jon Smirl wrote: > On Thu, Jul 29, 2010 at 10:17 PM, Maxim Levitsky > wrote: > > note that error_adjustment module option is added. > > This allows to reduce input samples by a percent. > > This makes input on my system more correct. > > > > Default is 4% as it works best here. > > > > Note that only normal input is adjusted. I don't know > > what adjustments to apply to fan tachometer input. > > Maybe it is accurate already. > > Do you have the manual for the ENE chip in English? or do you read Chinese? The datasheet for a similar chip, the KB3700, is out there in English, but it doesn't have CIR. You might find these links mildly interesting: http://www.coreboot.org/Embedded_controller http://wiki.laptop.org/go/Embedded_controller http://lists.laptop.org/pipermail/openec/2008-July/000108.html Regards, Andy > Maybe you can figure out why the readings are off by 4%. I suspect > that someone has set a clock divider wrong when programming the chip. > For example setting the divider for a 25Mhz clock when the clock is > actually 26Mhz would cause the error you are seeing. Or they just made > a mistake in computing the divisor. It is probably a bug in the BIOS > of your laptop. If that's the case you could add a quirk in the > system boot code to fix the register setting. >