From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Walls Subject: Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it. Date: Sat, 31 Jul 2010 09:55:31 -0400 Message-ID: <1280584531.2473.4.camel@localhost> References: <1280456235-2024-1-git-send-email-maximlevitsky@gmail.com> <1280456235-2024-14-git-send-email-maximlevitsky@gmail.com> <1280461565.15737.124.camel@localhost> <1280489761.3646.3.camel@maxim-laptop> <1280490865.21345.0.camel@maxim-laptop> <1280493911.22296.5.camel@maxim-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from proofpoint-cluster.metrocast.net ([65.175.128.136]:24023 "EHLO proofpoint-cluster.metrocast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753538Ab0GaNzP (ORCPT ); Sat, 31 Jul 2010 09:55:15 -0400 In-Reply-To: <1280493911.22296.5.camel@maxim-laptop> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Maxim Levitsky Cc: Jon Smirl , lirc-list@lists.sourceforge.net, Jarod Wilson , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab , Christoph Bartelmus On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: > On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: > > On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl wrote: > > > On Fri, Jul 30, 2010 at 7:54 AM, Maxim Levitsky wrote: > > > > > > > + pll_freq = (ene_hw_read_reg(dev, ENE_PLLFRH) << 4) + > > > + (ene_hw_read_reg(dev, ENE_PLLFRL) >> 2); > > > > > > I can understand the shift of the high bits, but that shift of the low > > bits is unlikely. A manual would tell us if it is right. > > > This shift is correct (according to datasheet, which contains mostly > useless info, but it does dociment this reg briefly.) The KB3700 series datasheet indicates that the value from ENE_PLLFRL should be shifted by >> 4 bits, not by >> 2. Of course, the KB3700 isn't the exact same chip. Regards, Andy