From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH 2.6.37? ] drivers/input: Use pr_<level>
Date: Wed, 04 Aug 2010 00:33:42 -0700
Message-ID: <1280907222.1005.63.camel@Joe-Laptop.home>
References: <1280860850.2963.24.camel@Joe-Laptop.home>
	 <20100804043256.GB25256@core.coreip.homeip.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-input-owner@vger.kernel.org>
Received: from mail.perches.com ([173.55.12.10]:2249 "EHLO mail.perches.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758526Ab0HDHdo (ORCPT <rfc822;linux-input@vger.kernel.org>);
	Wed, 4 Aug 2010 03:33:44 -0400
In-Reply-To: <20100804043256.GB25256@core.coreip.homeip.net>
Sender: linux-input-owner@vger.kernel.org
List-Id: linux-input@vger.kernel.org
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input <linux-input@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>

On Tue, 2010-08-03 at 21:32 -0700, Dmitry Torokhov wrote:
> Hi Joe,

Hi Dmitry.

> On Tue, Aug 03, 2010 at 11:40:50AM -0700, Joe Perches wrote:
> > Remove prefixes from printks and convert to pr_fmt/pr_<level>.
> Thanks for doing this, however instead of using pr_xxx() I'd like
> drivers that are integrated in driver model (serio, usb, gameport, etc,
> i.e. when we have 'struct device' available, exept for psmouse) to use
> drv_xxx() instead.

These files?
$ grep -rPl --include=*.[ch] "\bstruct\s+device\b" drivers/input | \
  xargs grep -wl pr_fmt
drivers/input/keyboard/omap-keypad.c
drivers/input/mousedev.c
drivers/input/serio/serio.c
drivers/input/serio/i8042.c
drivers/input/evdev.c
drivers/input/joydev.c
drivers/input/gameport/gameport.c
drivers/input/touchscreen/htcpen.c
drivers/input/input-polldev.c
drivers/input/input.c
drivers/input/tablet/aiptek.c
drivers/input/misc/winbond-cir.c
drivers/input/misc/yealink.c
drivers/input/misc/ati_remote2.c
drivers/input/misc/wistron_btns.c
drivers/input/misc/ati_remote.c
drivers/input/mouse/psmouse-base.c
  
> That would make synaptics messages to come as "psmouse", right?

Yes.

> I think we should use
> 	#define pr_fmt(fmt) "synaptics: " fmt
> here and in the rest of specialized PS/2 protocol handlers.

Perhaps convert to what elantech uses
#define pr_fmt(fmt) KBUILD_BASENAME ": " fmt

$ grep -l "define pr_fmt" drivers/input/mouse/*.[ch] | \
  xargs grep -il "ps2" 
drivers/input/mouse/alps.c
drivers/input/mouse/elantech.c
drivers/input/mouse/lifebook.c
drivers/input/mouse/logips2pp.c
drivers/input/mouse/psmouse-base.c
drivers/input/mouse/sentelic.c
drivers/input/mouse/synaptics.c
drivers/input/mouse/trackpoint.c

Which ones do you want converted? 
Any others?