From: Chase Douglas <chase.douglas@canonical.com>
To: linux-input@vger.kernel.org
Subject: [PATCH 4/6] HID: magicmouse: remove axis data filtering
Date: Mon, 30 Aug 2010 13:20:56 -0400 [thread overview]
Message-ID: <1283188858-4839-4-git-send-email-chase.douglas@canonical.com> (raw)
In-Reply-To: <1283188858-4839-1-git-send-email-chase.douglas@canonical.com>
The Magic Mouse device is very precise. No driver filtering of input
data needs to be performed.
Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
drivers/hid/hid-magicmouse.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
index f3ee6ab..65ec2f8 100644
--- a/drivers/hid/hid-magicmouse.c
+++ b/drivers/hid/hid-magicmouse.c
@@ -357,11 +357,11 @@ static void magicmouse_setup_input(struct input_dev *input, struct hid_device *h
__set_bit(EV_ABS, input->evbit);
input_set_abs_params(input, ABS_MT_TRACKING_ID, 0, 15, 0, 0);
- input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0, 255, 4, 0);
- input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0, 255, 4, 0);
- input_set_abs_params(input, ABS_MT_ORIENTATION, -32, 31, 1, 0);
+ input_set_abs_params(input, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0);
+ input_set_abs_params(input, ABS_MT_TOUCH_MINOR, 0, 255, 0, 0);
+ input_set_abs_params(input, ABS_MT_ORIENTATION, -32, 31, 0, 0);
input_set_abs_params(input, ABS_MT_POSITION_X, -1100, 1358,
- 4, 0);
+ 0, 0);
/* Note: Touch Y position from the device is inverted relative
* to how pointer motion is reported (and relative to how USB
* HID recommends the coordinates work). This driver keeps
@@ -369,7 +369,7 @@ static void magicmouse_setup_input(struct input_dev *input, struct hid_device *h
* inverse of the reported Y.
*/
input_set_abs_params(input, ABS_MT_POSITION_Y, -1589, 2047,
- 4, 0);
+ 0, 0);
}
if (report_undeciphered) {
--
1.7.1
next prev parent reply other threads:[~2010-08-30 17:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 17:20 [PATCH 1/6] HID: magicmouse: don't allow hidinput to initialize Chase Douglas
2010-08-30 17:20 ` [PATCH 2/6] HID: magicmouse: move features reports to static array Chase Douglas
2010-08-31 3:52 ` Michael Poole
2010-08-30 17:20 ` [PATCH 3/6] HID: magicmouse: simplify touch data bit manipulation Chase Douglas
2010-08-31 3:55 ` Michael Poole
2010-08-30 17:20 ` Chase Douglas [this message]
2010-08-31 3:59 ` [PATCH 4/6] HID: magicmouse: remove axis data filtering Michael Poole
2010-08-31 17:57 ` Chase Douglas
2010-08-30 17:20 ` [PATCH 5/6] HID: magicmouse: enable Magic Trackpad support Chase Douglas
2010-08-31 4:26 ` Michael Poole
2010-08-31 4:36 ` Michael Poole
2010-08-31 17:55 ` Chase Douglas
2010-08-31 17:54 ` Chase Douglas
2010-08-30 17:20 ` [PATCH 6/6] HID: magicmouse: Adjust major / minor axes to scale Chase Douglas
2010-08-31 4:28 ` Michael Poole
2010-08-31 3:46 ` [PATCH 1/6] HID: magicmouse: don't allow hidinput to initialize Michael Poole
2010-08-31 11:30 ` Michael Poole
2010-08-31 13:42 ` Chase Douglas
2010-08-31 17:49 ` Chase Douglas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283188858-4839-4-git-send-email-chase.douglas@canonical.com \
--to=chase.douglas@canonical.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).