From: Davidlohr Bueso <dave@gnu.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH] input: for best practices, return -ENOMEM instead of -1 when returning on mem allocation errors
Date: Thu, 23 Sep 2010 16:56:30 -0400 [thread overview]
Message-ID: <1285275390.1999.0.camel@cowboy> (raw)
In-Reply-To: <20100923154407.GA17807@core.coreip.homeip.net>
On Thu, 2010-09-23 at 08:44 -0700, Dmitry Torokhov wrote:
> On Thu, Sep 23, 2010 at 10:14:05AM -0400, Davidlohr Bueso wrote:
> > input: for best practices, return -ENOMEM instead of -1 when returning on mem allocation errors.
> >
> > Signed-off-by: Davidlohr Bueso <dave@gnu.org>
>
> Applied, thank you Davidlohr.
>
> FWIW there are more code in drivers/input/serio and drivers/input/mouse/
> that return -1 instead of a proper error codes.
>
Yes, I'll be preparing a patch shortly for those.
Thanks,
Davidlohr
prev parent reply other threads:[~2010-09-23 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 14:14 [PATCH] input: for best practices, return -ENOMEM instead of -1 when returning on mem allocation errors Davidlohr Bueso
2010-09-23 15:44 ` Dmitry Torokhov
2010-09-23 20:56 ` Davidlohr Bueso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285275390.1999.0.camel@cowboy \
--to=dave@gnu.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).