From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chase Douglas Subject: Re: [PATCH 5/6] hid: egalax: Add event filtering Date: Wed, 13 Oct 2010 13:55:13 -0400 Message-ID: <1286992513.31864.200.camel@mini> References: <1286978302-30034-1-git-send-email-rydberg@euromail.se> <1286978302-30034-6-git-send-email-rydberg@euromail.se> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from adelie.canonical.com ([91.189.90.139]:59886 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751457Ab0JMRzT (ORCPT ); Wed, 13 Oct 2010 13:55:19 -0400 In-Reply-To: <1286978302-30034-6-git-send-email-rydberg@euromail.se> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Henrik Rydberg Cc: Jiri Kosina , Dmitry Torokhov , Philipp Merkel , Stephane Chatty , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, 2010-10-13 at 15:58 +0200, Henrik Rydberg wrote: > Use estimated signal-to-noise ratios to reduce noise and limit the > amount of events emitted. > > Signed-off-by: Henrik Rydberg > --- > drivers/hid/hid-egalax.c | 16 ++++++++++------ > 1 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/hid/hid-egalax.c b/drivers/hid/hid-egalax.c > index 2aba897..b21e7dc 100644 > --- a/drivers/hid/hid-egalax.c > +++ b/drivers/hid/hid-egalax.c > @@ -27,6 +27,10 @@ MODULE_LICENSE("GPL"); > > #define MAX_EVENTS 120 > > +/* estimated signal-to-noise ratios */ > +#define SN_MOVE 1024 > +#define SN_PRESSURE 32 > + > struct egalax_data { > __u16 x, y, z; > __u8 id; > @@ -59,17 +63,17 @@ static int egalax_input_mapping(struct hid_device *hdev, struct hid_input *hi, > field->logical_maximum <<= 3; > hid_map_usage(hi, usage, bit, max, > EV_ABS, ABS_MT_POSITION_X); > - set_abs(input, ABS_MT_POSITION_X, field, 0); > + set_abs(input, ABS_MT_POSITION_X, field, SN_MOVE); > /* touchscreen emulation */ > - set_abs(input, ABS_X, field, 0); > + set_abs(input, ABS_X, field, SN_MOVE); > return 1; > case HID_GD_Y: > field->logical_maximum <<= 3; > hid_map_usage(hi, usage, bit, max, > EV_ABS, ABS_MT_POSITION_Y); > - set_abs(input, ABS_MT_POSITION_Y, field, 0); > + set_abs(input, ABS_MT_POSITION_Y, field, SN_MOVE); > /* touchscreen emulation */ > - set_abs(input, ABS_Y, field, 0); > + set_abs(input, ABS_Y, field, SN_MOVE); > return 1; > } > return 0; > @@ -96,9 +100,9 @@ static int egalax_input_mapping(struct hid_device *hdev, struct hid_input *hi, > field->logical_minimum = 0; > hid_map_usage(hi, usage, bit, max, > EV_ABS, ABS_MT_PRESSURE); > - set_abs(input, ABS_MT_PRESSURE, field, 0); > + set_abs(input, ABS_MT_PRESSURE, field, SN_PRESSURE); > /* touchscreen emulation */ > - set_abs(input, ABS_PRESSURE, field, 0); > + set_abs(input, ABS_PRESSURE, field, SN_PRESSURE); > return 1; > } > return 0; Seems obvious. Acked-by: Chase Douglas