linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Philipp Merkel <mail@philmerk.de>,
	Stephane Chatty <chatty@enac.fr>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Henrik Rydberg <rydberg@euromail.se>
Subject: [PATCH 5/6] hid: egalax: Add event filtering (rev2)
Date: Wed, 13 Oct 2010 22:30:24 +0200	[thread overview]
Message-ID: <1287001824-4132-1-git-send-email-rydberg@euromail.se> (raw)
In-Reply-To: <1286978302-30034-4-git-send-email-rydberg@euromail.se>

Use estimated signal-to-noise ratios to reduce noise and limit the
amount of events emitted.

Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
 drivers/hid/hid-egalax.c |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/hid/hid-egalax.c b/drivers/hid/hid-egalax.c
index b8025b9..78a2b3e 100644
--- a/drivers/hid/hid-egalax.c
+++ b/drivers/hid/hid-egalax.c
@@ -27,6 +27,10 @@ MODULE_LICENSE("GPL");
 
 #define MAX_EVENTS		120
 
+/* estimated signal-to-noise ratios */
+#define SN_MOVE			1024
+#define SN_PRESSURE		32
+
 struct egalax_data {
 	__u16 x, y, z;
 	__u8 id;
@@ -59,17 +63,17 @@ static int egalax_input_mapping(struct hid_device *hdev, struct hid_input *hi,
 			field->logical_maximum = 32760;
 			hid_map_usage(hi, usage, bit, max,
 					EV_ABS, ABS_MT_POSITION_X);
-			set_abs(input, ABS_MT_POSITION_X, field, 0);
+			set_abs(input, ABS_MT_POSITION_X, field, SN_MOVE);
 			/* touchscreen emulation */
-			set_abs(input, ABS_X, field, 0);
+			set_abs(input, ABS_X, field, SN_MOVE);
 			return 1;
 		case HID_GD_Y:
 			field->logical_maximum = 32760;
 			hid_map_usage(hi, usage, bit, max,
 					EV_ABS, ABS_MT_POSITION_Y);
-			set_abs(input, ABS_MT_POSITION_Y, field, 0);
+			set_abs(input, ABS_MT_POSITION_Y, field, SN_MOVE);
 			/* touchscreen emulation */
-			set_abs(input, ABS_Y, field, 0);
+			set_abs(input, ABS_Y, field, SN_MOVE);
 			return 1;
 		}
 		return 0;
@@ -96,9 +100,9 @@ static int egalax_input_mapping(struct hid_device *hdev, struct hid_input *hi,
 			field->logical_minimum = 0;
 			hid_map_usage(hi, usage, bit, max,
 					EV_ABS, ABS_MT_PRESSURE);
-			set_abs(input, ABS_MT_PRESSURE, field, 0);
+			set_abs(input, ABS_MT_PRESSURE, field, SN_PRESSURE);
 			/* touchscreen emulation */
-			set_abs(input, ABS_PRESSURE, field, 0);
+			set_abs(input, ABS_PRESSURE, field, SN_PRESSURE);
 			return 1;
 		}
 		return 0;
-- 
1.7.1


  parent reply	other threads:[~2010-10-13 20:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-13 13:58 [PATCH 0/6] hid: egalax: Rework to include joojoo support Henrik Rydberg
2010-10-13 13:58 ` [PATCH 1/6] hid: egalax: Use kzalloc Henrik Rydberg
2010-10-13 17:36   ` Chase Douglas
2010-11-04 14:41     ` Jiri Kosina
2010-10-13 13:58 ` [PATCH 2/6] hid: egalax: Setup input device manually Henrik Rydberg
2010-10-13 17:43   ` Chase Douglas
2010-10-13 13:58 ` [PATCH 3/6] hid: egalax: Correct for device resolution report error Henrik Rydberg
2010-10-13 17:43   ` Chase Douglas
2010-10-13 20:13   ` Henrik Rydberg
2010-10-13 20:29   ` [PATCH 3/6] hid: egalax: Correct for device resolution report error (rev2) Henrik Rydberg
2010-10-13 20:30   ` Henrik Rydberg [this message]
2010-10-13 13:58 ` [PATCH 4/6] hid: egalax: Report zero as minimum pressure Henrik Rydberg
2010-10-13 17:54   ` Chase Douglas
2010-10-13 13:58 ` [PATCH 5/6] hid: egalax: Add event filtering Henrik Rydberg
2010-10-13 17:55   ` Chase Douglas
2010-10-13 13:58 ` [PATCH 6/6] hid: egalax: Convert to MT slots Henrik Rydberg
2010-10-13 17:35   ` Chase Douglas
2010-10-15 14:37 ` [PATCH 0/6] hid: egalax: Rework to include joojoo support Jiri Kosina
2010-11-04 14:43 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287001824-4132-1-git-send-email-rydberg@euromail.se \
    --to=rydberg@euromail.se \
    --cc=chatty@enac.fr \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@philmerk.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).