From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: lirc-list@lists.sourceforge.net,
"Jarod Wilson" <jarod@wilsonet.com>,
"David Härdeman" <david@hardeman.nu>,
linux-input@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/5] IR: extend ir_raw_event and do refactoring
Date: Sat, 16 Oct 2010 06:11:46 +0200 [thread overview]
Message-ID: <1287202306.5156.2.camel@maxim-laptop> (raw)
In-Reply-To: <4CB91C05.3040904@infradead.org>
On Sat, 2010-10-16 at 00:29 -0300, Mauro Carvalho Chehab wrote:
> Em 15-10-2010 13:06, Maxim Levitsky escreveu:
> > Add new event types for timeout & carrier report
> > Move timeout handling from ir_raw_event_store_with_filter to
> > ir-lirc-codec, where it is really needed.
> > Now lirc bridge ensures proper gap handling.
> > Extend lirc bridge for carrier & timeout reports
> >
> > Note: all new ir_raw_event variables now should be initialized
> > like that: DEFINE_IR_RAW_EVENT(ev);
> >
> > To clean an existing event, use init_ir_raw_event(&ev);
> >
> > Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
> > Acked-by: Jarod Wilson <jarod@redhat.com>
>
>
> Applying patch patches/lmml_257371_2_5_ir_extend_ir_raw_event_and_do_refactoring.patch
> patching file drivers/media/IR/ene_ir.c
> patching file drivers/media/IR/ir-core-priv.h
> Hunk #1 succeeded at 88 (offset 6 lines).
> Hunk #2 succeeded at 121 (offset 6 lines).
> patching file drivers/media/IR/ir-jvc-decoder.c
> patching file drivers/media/IR/ir-lirc-codec.c
> Hunk #3 FAILED at 139.
> Hunk #4 FAILED at 167.
> Hunk #7 succeeded at 330 (offset 3 lines).
> 2 out of 7 hunks FAILED -- rejects in file drivers/media/IR/ir-lirc-codec.c
> patching file drivers/media/IR/ir-nec-decoder.c
> patching file drivers/media/IR/ir-raw-event.c
> patching file drivers/media/IR/ir-rc5-decoder.c
> patching file drivers/media/IR/ir-rc6-decoder.c
> patching file drivers/media/IR/ir-sony-decoder.c
> patching file drivers/media/IR/mceusb.c
> patching file drivers/media/IR/streamzap.c
> Hunk #1 FAILED at 170.
> Hunk #2 FAILED at 215.
> Hunk #3 FAILED at 233.
> Hunk #4 succeeded at 373 (offset -139 lines).
> 3 out of 4 hunks FAILED -- rejects in file drivers/media/IR/streamzap.c
> patching file include/media/ir-core.h
> Hunk #3 succeeded at 165 (offset 1 line).
> Patch patches/lmml_257371_2_5_ir_extend_ir_raw_event_and_do_refactoring.patch does not apply (enforce with -f)
> Patch didn't apply. Aborting
>
> Too much fails for me... -EABORTING...
>
> I won't apply this patch... there are two copies of it, and it has several broken hunks.
>
>
> Please fix.
Not surprising as v4l tree got many changes and that patch touches many
places.
Will redo that really against the media_tree :-)
Sorry!
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2010-10-16 4:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 16:06 [PATCH 0/8 V7] Many fixes for in-kernel decoding and for the ENE driver Maxim Levitsky
[not found] ` <1287158799-21486-1-git-send-email-maximlevitsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-15 16:06 ` [PATCH 1/5] IR: extend and sort the MCE keymap Maxim Levitsky
2010-10-15 19:48 ` Jarod Wilson
2010-10-15 16:06 ` [PATCH 2/5] IR: extend ir_raw_event and do refactoring Maxim Levitsky
2010-10-16 3:29 ` Mauro Carvalho Chehab
2010-10-16 4:11 ` Maxim Levitsky [this message]
2010-10-15 16:06 ` [PATCH 3/5] IR: ene_ir: few bugfixes Maxim Levitsky
2010-10-15 20:02 ` Jarod Wilson
[not found] ` <20101015200212.GK9658-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-15 20:24 ` Maxim Levitsky
2010-10-15 21:00 ` Jarod Wilson
2010-10-15 16:06 ` [PATCH 4/5] IR: ene_ir: add support for carrier reports Maxim Levitsky
2010-10-15 20:16 ` Jarod Wilson
2010-10-16 3:31 ` Mauro Carvalho Chehab
2010-10-15 16:06 ` [PATCH 5/5] IR: ene_ir: don't upload all settings on each TX packet Maxim Levitsky
2010-10-16 3:23 ` [PATCH 0/8 V7] Many fixes for in-kernel decoding and for the ENE driver Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287202306.5156.2.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=david@hardeman.nu \
--cc=jarod@wilsonet.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lirc-list@lists.sourceforge.net \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox