From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Andy Walls <awalls@md.metrocast.net>
Cc: lirc-list@lists.sourceforge.net,
"Jarod Wilson" <jarod@wilsonet.com>,
"David Härdeman" <david@hardeman.nu>,
mchehab@infradead.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 0/3] Remaining patches in my queue for IR
Date: Sun, 17 Oct 2010 03:07:18 +0200 [thread overview]
Message-ID: <1287277638.23804.3.camel@maxim-laptop> (raw)
In-Reply-To: <1287275805.11162.5.camel@morgan.silverblock.net>
On Sat, 2010-10-16 at 20:36 -0400, Andy Walls wrote:
> On Sun, 2010-10-17 at 00:56 +0200, Maxim Levitsky wrote:
> > Hi,
> >
> > This series is rebased on top of media_tree/staging/v2.6.37 only.
> > Really this time, sorry for cheating, last time :-)
> >
> > The first patch like we agreed extends the raw packets.
> > It touches all drivers (except imon as it isn't a raw IR driver).
>
> Will IR for the CX23885 and CX23888 still work given the changes?
>
> Here's the relevant files that use struct ir_raw_event:
>
> http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx23885/cx23885-input.c;h=bb61870b8d6ed39d25c11aa676b55bd0a94dc235;hb=staging/v2.6.37
> http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx25840/cx25840-ir.c;h=c2b4c14dc9ab533ff524b3e301235d6bdc92e2b9;hb=staging/v2.6.37
> http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx23885/cx23888-ir.c;h=2502a0a6709783b8c01d5de639d759d097f0f1cd;hb=staging/v2.6.37
>
> If needed, cx23885-input.c is where a fix can be made to ensure
> structure fields are properly zeroed until I have time to fix he lower
> level stuff.
>
> Regards,
> Andy
Wasn't aware of this as I only looked at IR directory. Will grep the
sources for more drivers.
Anyway the changes I propose are
straightforward, I shouldn't break the driver with it.
But of course if driver isn't updated it probably won't work.
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2010-10-17 1:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 22:56 [PATCH 0/3] Remaining patches in my queue for IR Maxim Levitsky
[not found] ` <1287269790-17605-1-git-send-email-maximlevitsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-16 22:56 ` [PATCH 1/3] IR: extend ir_raw_event and do refactoring Maxim Levitsky
2010-10-23 12:13 ` David Härdeman
2010-10-16 22:56 ` [PATCH 2/3] IR: ene_ir: add support for carrier reports Maxim Levitsky
2010-10-16 22:56 ` [PATCH 3/3] IR: ene_ir: don't upload all settings on each TX packet Maxim Levitsky
2010-10-17 0:36 ` [PATCH 0/3] Remaining patches in my queue for IR Andy Walls
2010-10-17 1:07 ` Maxim Levitsky [this message]
2010-10-20 18:40 ` Jarod Wilson
2010-10-22 0:17 ` Maxim Levitsky
2010-10-20 19:43 ` David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287277638.23804.3.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=awalls@md.metrocast.net \
--cc=david@hardeman.nu \
--cc=jarod@wilsonet.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lirc-list@lists.sourceforge.net \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox