From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_, pr_fmt. Fix dbg and __FILE__ use Date: Tue, 26 Oct 2010 18:10:25 -0700 Message-ID: <1288141825.4145.83.camel@Joe-Laptop> References: <20101026155028.GA13097@core.coreip.homeip.net> <1288135531.4145.59.camel@Joe-Laptop> <201010261740.13566.dmitry.torokhov@gmail.com> <1288140416.4145.76.camel@Joe-Laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: Jiri Kosina , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-input@vger.kernel.org On Tue, 2010-10-26 at 18:00 -0700, Dmitry Torokhov wrote: > On Oct 26, 2010, at 5:46 PM, Joe Perches wrote: > > On Tue, 2010-10-26 at 17:40 -0700, Dmitry Torokhov wrote: > >>> Mind if I move the time to the front like this? > >>> +#define dbg(format, arg...) \ > >>> +do { \ > >>> + if (i8042_debug) \ > >>> + printk(KERN_DEBUG KBUILD_MODNAME ": [%d]" format), \ > >>> + (int)(jiffies - i8042_start_time), ##arg); \ > >>> +} while (0) > >> Another option would be to leave '\n' in dbg() and leave most of the > >> callers as is. > > That's really error prone though. > In what way? $ grep -w dbg drivers/input/serio/i8042.c | cat -n 1 dbg("%02x <- i8042 (flush, %s)", data, 2 dbg("%02x -> i8042 (command)", command & 0xff); 3 dbg("%02x -> i8042 (parameter)", param[i]); 4 dbg(" -- i8042 (timeout)"); 5 dbg(" -- i8042 (auxerr)"); 6 dbg("%02x <- i8042 (return)", param[i]); 7 dbg("%02x -> i8042 (kbd-data)", c); 8 dbg("Extra keyboard ACK - filtered out\n"); 9 dbg("Filtered out by platform filter\n"); 10 if (irq) dbg("Interrupt %d, without any data", irq); 11 dbg("MUX error, status is %02x, data is %02x", str, data); 12 dbg("%02x <- i8042 (interrupt, %d, %d%s%s)", 13 dbg("%02x <- i8042 (aux_test_irq, %s)", 14 dbg(" -- i8042 (aux irq test timeout)"); 15 dbg("%02x -> i8042 (panic blink)", 0xed); 16 dbg("%02x -> i8042 (panic blink)", led); I think 2 defects in 16 uses is a pretty high error rate.