From: Ping Cheng <pinglinux@gmail.com>
To: linux-input@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, chris@cnpbagwell.com,
Ping Cheng <pingc@wacom.com>
Subject: [PATCH 1/3] Input: wacom - allow both MT and pen data to be reported
Date: Tue, 2 Nov 2010 16:37:59 -0700 [thread overview]
Message-ID: <1288741079-4993-1-git-send-email-pingc@wacom.com> (raw)
It was suggested by app and X server developers that both MT and pen data
should be reported to the userland if the data is valid. Bamboo series are
among these devices that both data are valid from the hardware perspective.
Signed-off-by: Ping Cheng <pingc@wacom.com>
---
drivers/input/tablet/wacom_wac.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index b3252ef..b9534a1 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -868,13 +868,14 @@ static int wacom_bpt_touch(struct wacom_wac *wacom)
for (i = 0; i < 2; i++) {
int p = data[9 * i + 2];
input_mt_slot(input, i);
- /*
- * Touch events need to be disabled while stylus is
- * in proximity because user's hand is resting on touchpad
- * and sending unwanted events. User expects tablet buttons
- * to continue working though.
+
+ /* We send touch events even a stylus is in proximity. Apps or
+ * userland clients have the opportunity to arbitrate these events
+ * when pen is in proximity.
+ * Wacom X server driver arbitrates the events for all apps that
+ * are based on X server.
*/
- if (p && !wacom->shared->stylus_in_proximity) {
+ if (p) {
int x = get_unaligned_be16(&data[9 * i + 3]) & 0x7ff;
int y = get_unaligned_be16(&data[9 * i + 5]) & 0x7ff;
if (features->quirks & WACOM_QUIRK_BBTOUCH_LOWRES) {
--
1.7.2.3
next reply other threads:[~2010-11-02 23:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 23:37 Ping Cheng [this message]
2010-11-03 9:44 ` [1/3] Input: wacom - allow both MT and pen data to be reported Henrik Rydberg
2010-11-03 14:10 ` [PATCH 1/3] " Chris Bagwell
2010-11-03 14:28 ` Dmitry Torokhov
2010-11-04 5:46 ` Peter Hutterer
2010-11-04 13:08 ` Chris Bagwell
2010-11-04 22:43 ` Peter Hutterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288741079-4993-1-git-send-email-pingc@wacom.com \
--to=pinglinux@gmail.com \
--cc=chris@cnpbagwell.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pingc@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).