From: jooaun <jasaw81@gmail.com>
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, raphaelpereira@gmail.com,
jooaun <jasaw81@gmail.com>
Subject: [PATCH 6/8] qt2160: only read device when Change pin is active
Date: Tue, 9 Nov 2010 13:45:38 +1100 [thread overview]
Message-ID: <1289270738-4297-1-git-send-email-jasaw81@gmail.com> (raw)
In-Reply-To: <1289268911-32322-6-git-send-email-jasaw81@gmail.com>
Check Change state and only read device when required.
Signed-off-by: Joo Aun Saw <jasaw81@gmail.com>
---
drivers/input/keyboard/qt2160.c | 12 ++++++++++++
include/linux/input/qt2160.h | 5 +++++
2 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/drivers/input/keyboard/qt2160.c b/drivers/input/keyboard/qt2160.c
index 7647849..8316fde 100755
--- a/drivers/input/keyboard/qt2160.c
+++ b/drivers/input/keyboard/qt2160.c
@@ -213,6 +213,12 @@ static irqreturn_t qt2160_irq(int irq, void *_qt2160)
struct qt2160_data *qt2160 = _qt2160;
unsigned long flags;
+ if (qt2160->hw_info->getchange) {
+ /* if change is not active, no IRQ to service */
+ if (qt2160->hw_info->getchange(qt2160->hw_info->data) > 0)
+ return IRQ_HANDLED;
+ }
+
spin_lock_irqsave(&qt2160->lock, flags);
__cancel_delayed_work(&qt2160->dwork);
@@ -225,6 +231,12 @@ static irqreturn_t qt2160_irq(int irq, void *_qt2160)
static void qt2160_schedule_read(struct qt2160_data *qt2160)
{
+ if (qt2160->hw_info->getchange) {
+ /* if change is not active, no need to read device */
+ if (qt2160->hw_info->getchange(qt2160->hw_info->data) > 0)
+ return;
+ }
+
spin_lock_irq(&qt2160->lock);
schedule_delayed_work(&qt2160->dwork, QT2160_CYCLE_INTERVAL);
spin_unlock_irq(&qt2160->lock);
diff --git a/include/linux/input/qt2160.h b/include/linux/input/qt2160.h
index 8a1913f..4eb7e18 100755
--- a/include/linux/input/qt2160.h
+++ b/include/linux/input/qt2160.h
@@ -7,6 +7,9 @@
/**
* struct qt2160_info - defines the chip configuration
+ * @data: private data for lowlevel IO abstraction routines
+ * @getchange: return 0 when CHANGE pin is active/low; return 1 when CHANGE pin
+ * is deactivated/high
* @slider_length: number of keys to use as slider, max 8 keys, min 2 keys
* @slider_axis: absolute axis type, value 0 is ABS_X
* @keycodes: key codes for keys that are part of the slider are ignored; slider
@@ -20,6 +23,8 @@
* sleep 16ms longer before detecting a touch (slower response); max 255
*/
struct qt2160_info {
+ void *data;
+ int (*getchange) (void *data);
unsigned char slider_length;
unsigned int slider_axis;
unsigned short keycodes[QT2160_MAXKEYS];
--
1.7.0.4
next prev parent reply other threads:[~2010-11-09 2:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 2:15 [PATCH 1/8] qt2160: add slider support jooaun
2010-11-09 2:15 ` [PATCH 2/8] qt2160: configurable key sensitivity jooaun
2010-11-09 2:43 ` jooaun
2010-11-09 2:15 ` [PATCH 3/8] qt2160: add PM support jooaun
2010-11-09 2:15 ` [PATCH 4/8] qt2160: add configurable power mode jooaun
2010-11-09 2:15 ` [PATCH 5/8] qt2160: fix starting of device calibration jooaun
2010-11-09 2:15 ` [PATCH 6/8] qt2160: only read device when Change pin is active jooaun
2010-11-09 2:45 ` jooaun [this message]
2010-11-09 2:15 ` [PATCH 7/8] qt2160: optional interrupt flag jooaun
2010-11-09 2:46 ` jooaun
2010-11-09 2:15 ` [PATCH 8/8] qt2160: add hardware reset jooaun
2010-11-09 2:47 ` jooaun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289270738-4297-1-git-send-email-jasaw81@gmail.com \
--to=jasaw81@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=raphaelpereira@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).